This is an automated email from the ASF dual-hosted git repository. pcristof pushed a commit to branch OPENJPA-2940 in repository https://gitbox.apache.org/repos/asf/openjpa.git
commit 1831cd4237813f3ae290fcb3d787b0a9680bc7e7 Author: Paulo Cristovão de Araújo Silva Filho <[email protected]> AuthorDate: Fri Sep 26 07:39:00 2025 -0300 [WIP][OPENJPA-2940] Remove LEFT and RIGHT tests for derbydb (does not support them) --- .../apache/openjpa/kernel/exps/InMemoryExpressionFactory.java | 2 +- .../openjpa/persistence/criteria/TestTypesafeCriteria.java | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/exps/InMemoryExpressionFactory.java b/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/exps/InMemoryExpressionFactory.java index 2f1f8f616..b0e7c0e20 100644 --- a/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/exps/InMemoryExpressionFactory.java +++ b/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/exps/InMemoryExpressionFactory.java @@ -728,7 +728,7 @@ public class InMemoryExpressionFactory @Override public Value replace(Value orig, Value pattern, Value replacement) { - throw new UnsupportedException("not implemented yet"); + return new Replace((Val) orig, (Val) pattern, (Val) replacement); } @Override diff --git a/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/criteria/TestTypesafeCriteria.java b/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/criteria/TestTypesafeCriteria.java index f85d6423c..d3e86b251 100644 --- a/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/criteria/TestTypesafeCriteria.java +++ b/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/criteria/TestTypesafeCriteria.java @@ -52,6 +52,7 @@ import jakarta.persistence.metamodel.EntityType; import jakarta.persistence.metamodel.Metamodel; import org.apache.openjpa.jdbc.sql.AbstractSQLServerDictionary; +import org.apache.openjpa.jdbc.sql.DerbyDictionary; import org.apache.openjpa.jdbc.sql.OracleDictionary; import org.apache.openjpa.persistence.common.utils.DatabaseHelper; import org.apache.openjpa.persistence.test.AllowFailure; @@ -1786,6 +1787,10 @@ public class TestTypesafeCriteria extends CriteriaTest { } public void testLeft() { + if (getDictionary() instanceof DerbyDictionary) { + // TODO Derby DB does not support LEFT, RIGHT or REPLACE functions + return; + } String jpql = "select p from Person p where left(p.name, 4) = 'John'"; em.getTransaction().begin(); Person p = new Person(); @@ -1802,6 +1807,10 @@ public class TestTypesafeCriteria extends CriteriaTest { } public void testRight() { + if (getDictionary() instanceof DerbyDictionary) { + // TODO Derby DB does not support LEFT, RIGHT or REPLACE functions + return; + } String jpql = "select p from Person p where RIGHT(p.name, 3) = 'Doe'"; em.getTransaction().begin(); Person p = new Person();
