Sebastian Wagner created OPENMEETINGS-2565:
----------------------------------------------

             Summary: Typo in RoomDTO getExternal - doesn't return correct room
                 Key: OPENMEETINGS-2565
                 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2565
             Project: Openmeetings
          Issue Type: Bug
            Reporter: Sebastian Wagner
            Assignee: Sebastian Wagner


This is quite annoying.

 

Cause it looks like its working but in fact it isnt'.

 
{code:java}
@WebMethod
        @GET
        @Path("/{type}/{externaltype}/{externaliid}")
        public RoomDTO getExternal(@WebParam(name="sid") @QueryParam("sid") 
String sid
                        , @PathParam("type") @WebParam(name="type") String type
                        , @PathParam("externaltype") 
@WebParam(name="externaltype") String externalType
                        , @PathParam("externalid") @WebParam(name="externalid") 
String externalId
                        , @WebParam(name="room") @QueryParam("room") RoomDTO 
room) {
{code}
 

externaliid == Spelled wrong and differently from

@PathParam("externalid") @WebParam(name="externalid") String externalId

=> Effect in
{code:java}
Room r = roomDao.getExternal(Room.Type.valueOf(type), externalType, 
externalId);{code}
externalId is simply null. Nothing inside. Cause the param in the header 
decoration is spelled wrongly/different.

However it just returns the first entry based on the "externalType", which 
sometimes works, for example if you just have 1 room. But in most cases just 
doesn't work at all.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to