[ https://issues.apache.org/jira/browse/OPENMEETINGS-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277961#comment-17277961 ]
ASF subversion and git services commented on OPENMEETINGS-2565: --------------------------------------------------------------- Commit afa5d9104b43e3fdc7feb4fcd0f7302a6f822797 in openmeetings's branch refs/heads/feature/typo-in-get-room-by-externalid from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=afa5d91 ] [OPENMEETINGS-2565] test is added > Typo in RoomDTO getExternal - doesn't return correct room > --------------------------------------------------------- > > Key: OPENMEETINGS-2565 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2565 > Project: Openmeetings > Issue Type: Bug > Reporter: Sebastian Wagner > Assignee: Sebastian Wagner > Priority: Major > Fix For: 6.0.0 > > > This is quite annoying. > > Cause it looks like its working but in fact it isnt'. > > {code:java} > @WebMethod > @GET > @Path("/{type}/{externaltype}/{externaliid}") > public RoomDTO getExternal(@WebParam(name="sid") @QueryParam("sid") > String sid > , @PathParam("type") @WebParam(name="type") String type > , @PathParam("externaltype") > @WebParam(name="externaltype") String externalType > , @PathParam("externalid") @WebParam(name="externalid") > String externalId > , @WebParam(name="room") @QueryParam("room") RoomDTO > room) { > {code} > > externaliid == Spelled wrong and differently from > @PathParam("externalid") @WebParam(name="externalid") String externalId > => Effect in > {code:java} > Room r = roomDao.getExternal(Room.Type.valueOf(type), externalType, > externalId);{code} > externalId is simply null. Nothing inside. Cause the param in the header > decoration is spelled wrongly/different. > However it just returns the first entry based on the "externalType", which > sometimes works, for example if you just have 1 room. But in most cases just > doesn't work at all. > -- This message was sent by Atlassian Jira (v8.3.4#803005)