[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432235#comment-17432235
 ] 

ASF subversion and git services commented on OPENMEETINGS-2692:
---------------------------------------------------------------

Commit b25113ae2098a044bf29f97044b10e5756056211 in openmeetings's branch 
refs/heads/release-6-2-0 from Sebastian Wagner
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=b25113a ]

Merge pull request #166 from 
apache/feature/OPENMEETINGS-2692-update-webapp-path-for-manifest-references

OPENMEETINGS-2692 Update review comments on parsing path element.

> Update manifest file path to use application.base.url
> -----------------------------------------------------
>
>                 Key: OPENMEETINGS-2692
>                 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2692
>             Project: Openmeetings
>          Issue Type: Task
>          Components: Mobile client
>    Affects Versions: 7.0.0
>            Reporter: Sebastian Wagner
>            Assignee: Sebastian Wagner
>            Priority: Major
>             Fix For: 6.2.0
>
>
> Address webapp path.
>  
> [~solomax]: 
> {quote}this might be very inaccurate
>  for ex. OpenmeetingsVariables.getApplicationName() == OpenMeetings - Next
>  
> I believe it's better to use application.base.url for this
>  
> And since this is calculated I would create and pass variable or create 
> method for this
> {quote}
>  
> See: [https://github.com/apache/openmeetings/pull/164#discussion_r730433443]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to