This is an automated email from the ASF dual-hosted git repository.
joern pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/opennlp.git
The following commit(s) were added to refs/heads/master by this push:
new 79237dc OPENNLP-1199: Correct loop bounds NGramGenerator.generate
79237dc is described below
commit 79237dcd2bf537d56ff8d73f897cd639af7bf8f7
Author: Prachi Prakash <[email protected]>
AuthorDate: Tue May 22 15:37:41 2018 +0530
OPENNLP-1199: Correct loop bounds NGramGenerator.generate
---
.../java/opennlp/tools/ngram/NGramGenerator.java | 35 +++++++++++-----------
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git
a/opennlp-tools/src/main/java/opennlp/tools/ngram/NGramGenerator.java
b/opennlp-tools/src/main/java/opennlp/tools/ngram/NGramGenerator.java
index 6c470bc..d090f29 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/ngram/NGramGenerator.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/ngram/NGramGenerator.java
@@ -41,17 +41,17 @@ public class NGramGenerator {
public static List<String> generate(List<String> input, int n, String
separator) {
List<String> outGrams = new ArrayList<>();
- for (int i = 0; i < input.size() - (n - 2); i++) {
+ for (int i = 0; i < input.size() - (n - 1); i++) {
final StringBuilder sb = new StringBuilder();
- if ((i + n) <= input.size()) {
- for (int x = i; x < (n + i); x++) {
- sb.append(input.get(x));
- sb.append(separator);
- }
- String gram = sb.toString();
- gram = gram.substring(0, gram.lastIndexOf(separator));
- outGrams.add(gram);
+
+ for (int x = i; x < (n + i); x++) {
+ sb.append(input.get(x));
+ sb.append(separator);
}
+ String gram = sb.toString();
+ gram = gram.substring(0, gram.lastIndexOf(separator));
+ outGrams.add(gram);
+
}
return outGrams;
}
@@ -67,17 +67,16 @@ public class NGramGenerator {
public static List<String> generate(char[] input, int n, String separator) {
List<String> outGrams = new ArrayList<>();
- for (int i = 0; i < input.length - (n - 2); i++) {
+ for (int i = 0; i < input.length - (n - 1); i++) {
final StringBuilder sb = new StringBuilder();
- if ((i + n) <= input.length) {
- for (int x = i; x < (n + i); x++) {
- sb.append(input[x]);
- sb.append(separator);
- }
- String gram = sb.toString();
- gram = gram.substring(0, gram.lastIndexOf(separator));
- outGrams.add(gram);
+
+ for (int x = i; x < (n + i); x++) {
+ sb.append(input[x]);
+ sb.append(separator);
}
+ String gram = sb.toString();
+ gram = gram.substring(0, gram.lastIndexOf(separator));
+ outGrams.add(gram);
}
return outGrams;
}
--
To stop receiving notification emails like this one, please contact
[email protected].
