This is an automated email from the ASF dual-hosted git repository. rzo1 pushed a commit to branch OPENNLP-1589 in repository https://gitbox.apache.org/repos/asf/opennlp.git
commit 60e080caea70b0326a67208db9c02a13c45a57c1 Author: Richard Zowalla <[email protected]> AuthorDate: Thu Jul 4 13:48:40 2024 +0200 OPENNLP-1589 - Demonstrate that caching based on identity is broken. --- .../opennlp/tools/util/featuregen/CachedFeatureGeneratorTest.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/opennlp-tools/src/test/java/opennlp/tools/util/featuregen/CachedFeatureGeneratorTest.java b/opennlp-tools/src/test/java/opennlp/tools/util/featuregen/CachedFeatureGeneratorTest.java index 05861852..0dcb10a8 100644 --- a/opennlp-tools/src/test/java/opennlp/tools/util/featuregen/CachedFeatureGeneratorTest.java +++ b/opennlp-tools/src/test/java/opennlp/tools/util/featuregen/CachedFeatureGeneratorTest.java @@ -18,6 +18,7 @@ package opennlp.tools.util.featuregen; import java.util.ArrayList; +import java.util.Arrays; import java.util.List; import org.junit.jupiter.api.Assertions; @@ -70,9 +71,7 @@ public class CachedFeatureGeneratorTest { final String expectedToken = testSentence1[testIndex]; - testSentence1[testIndex] = null; - - generator.createFeatures(features, testSentence1, testIndex, null); + generator.createFeatures(features, Arrays.copyOf(testSentence1, testSentence1.length), testIndex, null); Assertions.assertEquals(1, generator.getNumberOfCacheMisses()); Assertions.assertEquals(1, generator.getNumberOfCacheHits()); @@ -86,7 +85,7 @@ public class CachedFeatureGeneratorTest { int testIndex2 = testIndex + 1; - generator.createFeatures(features, testSentence1, testIndex2, null); + generator.createFeatures(features, Arrays.copyOf(testSentence1, testSentence1.length), testIndex2, null); Assertions.assertEquals(2, generator.getNumberOfCacheMisses()); Assertions.assertEquals(1, generator.getNumberOfCacheHits());
