(opennlp) branch opennlp-2.x updated: OPENNLP-1753: Switch to Models v1.3 (OpenNLP 2.x)

[mawiesne]

This is an automated email from the ASF dual-hosted git repository.

mawiesne pushed a commit to branch opennlp-2.x
in repository https://gitbox.apache.org/repos/asf/opennlp.git


The following commit(s) were added to refs/heads/opennlp-2.x by this push:
     new 1700b9fe OPENNLP-1753: Switch to Models v1.3 (OpenNLP 2.x)
1700b9fe is described below

commit 1700b9fef3949d2327606221bb1a3d696586401d
Author: Martin Wiesner <martin.wies...@hs-heilbronn.de>
AuthorDate: Wed Jul 9 09:20:28 2025 +0200

    OPENNLP-1753: Switch to Models v1.3 (OpenNLP 2.x)
    
    - adds missing newly supported lang codes to DownloadUtil's internal map
    - adds missing newly supported lang codes to AbstractModelLoaderTest classes
---
 opennlp-tools/src/main/java/opennlp/tools/util/DownloadUtil.java  | 8 ++++++++
 .../src/test/java/opennlp/tools/AbstractModelLoaderTest.java      | 8 ++++----
 .../src/test/java/opennlp/tools/util/DownloadParserTest.java      | 2 +-
 3 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/opennlp-tools/src/main/java/opennlp/tools/util/DownloadUtil.java 
b/opennlp-tools/src/main/java/opennlp/tools/util/DownloadUtil.java
index a1c52031..5160111e 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/util/DownloadUtil.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/util/DownloadUtil.java
@@ -273,6 +273,8 @@ public class DownloadUtil {
             addModel("nl", link, result);
           } else if (link.contains("fr-ud")) { // French
             addModel("fr", link, result);
+          } else if (link.contains("af-ud")) { // Afrikaans
+            addModel("af", link, result);
           } else if (link.contains("bg-ud")) { // Bulgarian
             addModel("bg", link, result);
           } else if (link.contains("ca-ud")) { // Catalan
@@ -291,12 +293,18 @@ public class DownloadUtil {
             addModel("et", link, result);
           } else if (link.contains("eu-ud")) { // Basque
             addModel("eu", link, result);
+          } else if (link.contains("fa-ud")) { // Persian
+            addModel("fa", link, result);
           } else if (link.contains("fi-ud")) { // Finnish
             addModel("fi", link, result);
+          } else if (link.contains("ga-ud")) { // Irish
+            addModel("ga", link, result);
           } else if (link.contains("hy-ud")) { // Armenian
             addModel("hy", link, result);
           } else if (link.contains("is-ud")) { // Icelandic
             addModel("is", link, result);
+          } else if (link.contains("id-ud")) { // Indonesian
+            addModel("id", link, result);
           } else if (link.contains("ka-ud")) { // Georgian
             addModel("ka", link, result);
           } else if (link.contains("kk-ud")) { // Kazakh
diff --git 
a/opennlp-tools/src/test/java/opennlp/tools/AbstractModelLoaderTest.java 
b/opennlp-tools/src/test/java/opennlp/tools/AbstractModelLoaderTest.java
index 53ec0298..059a07d3 100644
--- a/opennlp-tools/src/test/java/opennlp/tools/AbstractModelLoaderTest.java
+++ b/opennlp-tools/src/test/java/opennlp/tools/AbstractModelLoaderTest.java
@@ -41,10 +41,10 @@ public abstract class AbstractModelLoaderTest {
   protected static final String VER = "1.3-2.5.4";
   protected static final String BIN = ".bin";
   protected static List<String> SUPPORTED_LANG_CODES = List.of(
-          "en", "fr", "de", "it", "nl", "bg", "ca", "cs", "da", "el",
-          "es", "et", "eu", "fi", "hr", "hy", "is", "ka", "kk", "ko",
-          "lv", "no", "pl", "pt", "ro", "ru", "sk", "sl", "sr", "sv",
-          "tr", "uk");
+          "af", "en", "fr", "de", "it", "nl", "bg", "ca", "cs", "da", "el",
+          "es", "et", "eu", "fa", "fi", "ga", "hr", "hy", "id", "is", "ka",
+          "kk", "ko", "lv", "no", "pl", "pt", "ro", "ru", "sk", "sl", "sr",
+          "sv", "tr", "uk");
 
   protected static void downloadVersion15Model(String modelName) throws 
IOException {
     downloadModel(new URL(BASE_URL_MODELS_V15 + modelName));
diff --git 
a/opennlp-tools/src/test/java/opennlp/tools/util/DownloadParserTest.java 
b/opennlp-tools/src/test/java/opennlp/tools/util/DownloadParserTest.java
index bc74ca6e..b2d360bd 100644
--- a/opennlp-tools/src/test/java/opennlp/tools/util/DownloadParserTest.java
+++ b/opennlp-tools/src/test/java/opennlp/tools/util/DownloadParserTest.java
@@ -47,7 +47,7 @@ public class DownloadParserTest {
     Map<String, Map<ModelType, String>> result = 
downloadParser.getAvailableModels();
 
     assertNotNull(result);
-    assertEquals(32, result.size());
+    assertEquals(36, result.size());
 
     final Map<ModelType, String> availableModels = result.get(language);
     assertNotNull(availableModels);