krickert commented on PR #1478: URL: https://github.com/apache/opennlp/pull/1478#issuecomment-6115625411
Thanks, done in the new push: - Dropped `ParserBuilder`; the new `ParserFactory.create(model, tagger, chunker, beamSize, advancePercentage)` covers the use case. - Added `ParamChecks.requirePositive(int, String)` (same signature as #1323) and `requirePositiveFraction(double, String)` for (0, 1], both tested in `ParamChecksTest`; `AbstractBottomUpParser` uses them. The other copies are left for a separate issue as suggested. - One `@ParameterizedTest` per entry point for nulls and one for out-of-range values, plus accept rows for beam size 1 and advance percentage 1.0 and 0.01. - `parser.xml` describes the current behaviour without the version. - README lists the stricter beam size and advance percentage checks as breaking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
