This is an automated email from the ASF dual-hosted git repository. rmannibucau pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/openwebbeans.git
The following commit(s) were added to refs/heads/master by this push: new 2274603 [OWB-1366] since we should never have errors there ensure to create a logger only if there is an error in WB logger facade static block 2274603 is described below commit 2274603e24cdbf39e3c414b05ac4f054ba4895f6 Author: Romain Manni-Bucau <rmannibu...@gmail.com> AuthorDate: Tue Jan 5 14:27:44 2021 +0100 [OWB-1366] since we should never have errors there ensure to create a logger only if there is an error in WB logger facade static block --- .../main/java/org/apache/webbeans/logger/WebBeansLoggerFacade.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/webbeans-impl/src/main/java/org/apache/webbeans/logger/WebBeansLoggerFacade.java b/webbeans-impl/src/main/java/org/apache/webbeans/logger/WebBeansLoggerFacade.java index fc47060..5796fc5 100644 --- a/webbeans-impl/src/main/java/org/apache/webbeans/logger/WebBeansLoggerFacade.java +++ b/webbeans-impl/src/main/java/org/apache/webbeans/logger/WebBeansLoggerFacade.java @@ -90,10 +90,10 @@ public final class WebBeansLoggerFacade .orElseGet(JULLoggerFactory::new); } - Logger logger = FACTORY.getLogger(WebBeansLoggerFacade.class); - if (error != null && logger.isLoggable(Level.SEVERE)) + // ensure to not create any logger if there is no error + if (error != null && FACTORY.getLogger(WebBeansLoggerFacade.class).isLoggable(Level.SEVERE)) { - logger.log(Level.SEVERE, OWBLogConst.ERROR_0028, error); + FACTORY.getLogger(WebBeansLoggerFacade.class).log(Level.SEVERE, OWBLogConst.ERROR_0028, error); } }