ddragosd commented on issue #2256: surface errors in runtimes.manifest configuration in the controller logs URL: https://github.com/apache/incubator-openwhisk/pull/2256#issuecomment-302262715 > You can change the method to return the try and then throw the exception in the controller's main. `ExecManifest.initialize` is called by both: controller and invoker. would you suggest we impl in both of them ? Open to your suggestion, but before making the change I want to make sure we're ok to duplicate the code. > There's no point to using a try if this method is going to throw an exception. I also thought of that but I changed my mind seeing we have 3 operations to `Try`: `parse`, `flatMap`, and `map`, and the intent is to throw an exception only on error. Let me know what you think. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
