rabbah commented on a change in pull request #2282: Distributed tracing support
#2192
URL:
https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r118590441
##########
File path:
core/controller/src/main/scala/whisk/core/controller/Controller.scala
##########
@@ -171,8 +173,8 @@ object Controller {
def main(args: Array[String]): Unit = {
implicit val actorSystem = ActorSystem("controller-actor-system")
- implicit val logger = new
AkkaLogging(akka.event.Logging.getLogger(actorSystem, this))
-
+ implicit val logger = new ZipkinLogging(new
AkkaLogging(akka.event.Logging.getLogger(actorSystem, this)))
Review comment:
I prefer a model where the additional logging and tracing driver is done
through a configuration file (or deployment parameters) and loaded
_reflectively_; This means the drivers can be developed externally and loaded
as desired.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
