This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-1.7
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/branch-1.7 by this push:
new 959e1ca ORC-1091: Add `Tests` section at ORC `develop` page (#1011)
959e1ca is described below
commit 959e1cafdcabe5eb1de6489152543bef99c1e7ca
Author: Dongjoon Hyun <[email protected]>
AuthorDate: Thu Jan 13 21:35:02 2022 -0800
ORC-1091: Add `Tests` section at ORC `develop` page (#1011)
### What changes were proposed in this pull request?
This PR aims to add `Tests` section at Apache ORC `develop` web page.
### Why are the changes needed?
To help review process.
### How was this patch tested?
Manually because this is a doc-only change.
(cherry picked from commit d82e0f26814f2448eb262a91a2f90fe501d70f23)
Signed-off-by: Dongjoon Hyun <[email protected]>
---
site/develop/index.md | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/site/develop/index.md b/site/develop/index.md
index cf89550..eea3891 100644
--- a/site/develop/index.md
+++ b/site/develop/index.md
@@ -91,6 +91,39 @@ From our website, you can use:
ORC uses Commit-Then-Review, so patches can be committed without a
committer's review. However, most changes should be reviewed first.
+## Tests
+
+In principle, new pull requests had better provide test coverage for newly
proposed code path.
+In addition, newly added test cases are supposed to fail without the proposed
main code.
+In other words, reviewers need to check these two things during the review
manually.
+The following is useful during Java code review and tests.
+
+### Running Individual Java Test File
+
+~~~~
+% cd java
+% ./mvnw test -pl core -Dtest=TestRecordReaderImpl
+~~~~
+
+### Running Multiple Java Test Files
+
+~~~~
+% cd java
+% ./mvnw test -pl core -Dtest='Test*Reader*'
+~~~~
+
+### Running Individual Java Test Case
+~~~~
+% cd java
+$ ./mvnw test -pl core -Dtest=TestRecordReaderImpl#testFindColumn
+~~~~
+
+### Running Multiple Java Test Cases
+~~~~
+% cd java
+% ./mvnw test -pl core -Dtest='TestRecordReaderImpl#testFind*'
+~~~~
+
## Approving a pull request
Fetch the current state of the project:
