Commit by: stearns
Modified files:
chandler/application/Application.py 1.306 1.307
chandler/parcels/osaf/framework/blocks/detail/Detail.py 1.99 1.100

Log message:
Fix 2317 again (checking the 'all day' check box doesn't reflect it in the week 
and day views), r=capps:
- Don't use needsUpdateUI to trigger the update at idle time - always call 
updateOnIdle.
- Don't call the notification callbacks if we had no changes.

ViewCVS links:
http://cvs.osafoundation.org/index.cgi/chandler/application/Application.py.diff?r1=text&tr1=1.306&r2=text&tr2=1.307
http://cvs.osafoundation.org/index.cgi/chandler/parcels/osaf/framework/blocks/detail/Detail.py.diff?r1=text&tr1=1.99&r2=text&tr2=1.100

Index: chandler/parcels/osaf/framework/blocks/detail/Detail.py
diff -u chandler/parcels/osaf/framework/blocks/detail/Detail.py:1.99 
chandler/parcels/osaf/framework/blocks/detail/Detail.py:1.100
--- chandler/parcels/osaf/framework/blocks/detail/Detail.py:1.99        Mon Mar 
 7 10:34:29 2005
+++ chandler/parcels/osaf/framework/blocks/detail/Detail.py     Tue Mar  8 
10:18:07 2005
@@ -1,5 +1,5 @@
-__version__ = "$Revision: 1.99 $"
-__date__ = "$Date: 2005/03/07 18:34:29 $"
+__version__ = "$Revision: 1.100 $"
+__date__ = "$Date: 2005/03/08 18:18:07 $"
 __copyright__ = "Copyright (c) 2004-2005 Open Source Applications Foundation"
 __license__ = "http://osafoundation.org/Chandler_0.1_license_terms.htm";
 
@@ -1142,7 +1142,6 @@
         if item is not None:
             item.allDay = self.widget.GetValue() == wx.CHK_CHECKED
             self.resynchronizeDetailView()
-            wx.GetApp().needsUpdateUI = True
 
 class EditReminder (DetailSynchronizer, ControlBlocks.Choice):
     """

Index: chandler/application/Application.py
diff -u chandler/application/Application.py:1.306 
chandler/application/Application.py:1.307
--- chandler/application/Application.py:1.306   Mon Mar  7 10:34:29 2005
+++ chandler/application/Application.py Tue Mar  8 10:18:06 2005
@@ -1,5 +1,5 @@
-__version__ = "$Revision: 1.306 $"
-__date__ = "$Date: 2005/03/07 18:34:29 $"
+__version__ = "$Revision: 1.307 $"
+__date__ = "$Date: 2005/03/08 18:18:06 $"
 __copyright__ = "Copyright (c) 2003-2004 Open Source Applications Foundation"
 __license__ = "http://osafoundation.org/Chandler_0.1_license_terms.htm";
 
@@ -539,14 +539,16 @@
             the_view.mapChanges(mapChangesCallable, True)
     
             # grab the list of subscribed callbacks and notify them.
-            for i in self.repository._notifications: 
-                i(the_view, changes, "changeonly")
+            if changes:
+                for i in self.repository._notifications: 
+                    i(the_view, changes, "changeonly")
 
         focus = wx.Window_FindFocus()
-        if self.focus != focus or self.needsUpdateUI:
+        if self.focus != focus:
             self.focus = focus
             self.needsUpdateUI = True
-            updateOnIdle()
+
+        updateOnIdle()
 
         if self.needsUpdateUI:
             try:

_______________________________________________
Commits mailing list
Commits@osafoundation.org
http://lists.osafoundation.org/mailman/listinfo/commits

Reply via email to