smccarthy788 commented on PR #87: URL: https://github.com/apache/otava/pull/87#issuecomment-3201533066
Hey Joe, Thanks for offering to help. I pushed up a couple changes. There wasn’t much left. Review feedback would be much appreciated! Sean > On Aug 19, 2025, at 9:21 AM, Joe Drumgoole ***@***.***> wrote: > > > jdrumgoole > left a comment > (apache/otava#87) > <https://github.com/apache/otava/pull/87#issuecomment-3200749207>Hey Sean, > > Can I help with getting your PR merged? > > Joe. > > > On Tue, 12 Aug 2025 at 17:54, Joe Drumgoole ***@***.***> wrote: > > > Sean, I can withdraw my PR and wait for yours to be merged. > > > > > > Joe Drumgoole > > > > +087 2995547 > > https://bsky.app/profile/joedrumgoole.com > > > > > > > > On Tue 12 Aug 2025, 15:31 Sean McCarthy, ***@***.***> wrote: > > > >> *smccarthy788* left a comment (apache/otava#87) > >> <https://github.com/apache/otava/pull/87#issuecomment-3179607686> > >> > >> I have a PR which will remove expandvars entirely: #86 > >> <https://github.com/apache/otava/pull/86>. I think that was one of the > >> goals for #82 <https://github.com/apache/otava/issues/82>, to remove > >> arbitrary environment variables from the config. Happy for any feedback on > >> that PR though! > >> > >> — > >> Reply to this email directly, view it on GitHub > >> <https://github.com/apache/otava/pull/87#issuecomment-3179607686>, or > >> unsubscribe > >> <https://github.com/notifications/unsubscribe-auth/AAAXYDU45KAB64OU2NPSGZL3NH3EBAVCNFSM6AAAAACDWUARNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNZZGYYDONRYGY> > >> . > >> You are receiving this because you authored the thread.Message ID: > >> ***@***.***> > >> > > > > -- > > Joe Drumgoole > > +087 2995547 > https://bsky.app/profile/joedrumgoole.com > — > Reply to this email directly, view it on GitHub <https://github.com/apache/otava/pull/87#issuecomment-3200749207>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABSLUQP5XSLCG7TQAKH23YL3OMQGTAVCNFSM6AAAAACDWUARNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMBQG42DSMRQG4>. > You are receiving this because you commented. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
