Sowiks commented on PR #96: URL: https://github.com/apache/otava/pull/96#issuecomment-3567506690
1. Brought comments, code, and variable names across all files to the same indexing notations that are related to sub-series. Now everything is defined in the python slice notations, i.e., array[start : end]. First index `start` always included, last index `end` always excluded. Variable usage `start` and `end` is also consistent throughout the files. Variable name `stop` is not used, except for cases when working with python built-in slice object directly (in those cases the slice object field `stop` is equal to variables `end`). 2. Added comments describing original and split-merge change point detection algorithms. Got rid of mongodb implementation references in the comments. 3. Corrected assert statement in `analysis.py` 4. Added comments in `analysis.py` explaining `None` values for intervals.start and intervals.stop 5. Renamed `_calculated_distances` method to `_calculate_pairwise_differences` in `PairDistanceCalculator` class in `calculator.py` 6. Renamed significance threshold variable `alpha` to `max_pvalue` across all files for consistence and clarity 7. Corrected typos in variable name `permurations` to `permutations` across all files 8. Corrected annotation typo for variable `power` in `calculator.py` (`int` to `float`) 9. Corrected typo in `calculator.py` (`matix` to `matrix`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
