Gerrrr opened a new pull request, #124: URL: https://github.com/apache/otava/pull/124
This PR contains my understanding of what we want to achieve in https://github.com/apache/otava/issues/118. Changes: - `regressions` command is removed as a Datastax-specific thing. `analyze` covers all interesting use cases. - `analyze --branch` is ConfigArgParsified and can be configured via `BRANCH` env variable. - Configuration syntax for `analyze --branch` is unified as much as possible across importers. As a standard, I used Graphite `%BRANCH` syntax. It is reused it in Postgres and BigQuery importers plus. Csv importer has its own thing. It looks at a `branch` column and behaves in the following way: 1. If there is no branch column and `--branch` is not specified, it works as before. 2. If there is a branch column and `--branch` is not specified, the importer checks that that column contains a unique value a guardrail against mixing results between different branches. 3. If there is a branch column and `--branch` is specified, the importer will filter out values for rows where the value in branch column is not equal to the passed value. 4. If there is no branch column and `--branch` is specified, the importer throws. - There is no default value for `--branch` now and a test config has at least one `%BRANCH`, a user must pass it. - %{BRANCH} is escaped against SQL injections in PostgreSQL and BigQuery, just in case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
