henrikingo commented on PR #127: URL: https://github.com/apache/otava/pull/127#issuecomment-3923482536
> Otherwise you might get differences based on changes that are just further ahead on master Ah that's right. I forgot about this. Is that what --since-commit does/did? I thought it was essentially a synonym for --last??? Can you explain a bit more, how do you provide the data to Otava when you are dealing with a pull request? (I'm not sure this works the same with all the databases...) I just realized in some cases a PR would not be anything special: It is just a history of git commits (child->parent) and it starts (or ends, rather) with the tip of the feature branch. On the other hand if you think of the PR branch as just one or a few commits, then appending them to the end of the main branch is indeed often wrong. It seems I use the commit time to determine the right position of the pr commit in the main branch history. I remember spending some time convincing myself that this is equivalent to looking at merge-base or the chain of parent refrerenses. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
