henrikingo commented on code in PR #145: URL: https://github.com/apache/otava/pull/145#discussion_r3033457837
########## docs_sphinx/source/index.rst: ########## @@ -0,0 +1,17 @@ +Welcome to Apache Otava Documentation +===================================== + +This documentation is powered by Sphinx and supports Markdown via MyST. Review Comment: This would IMO fit better at the very end of this page. ########## docs_sphinx/make.bat: ########## @@ -0,0 +1,35 @@ +@ECHO OFF Review Comment: Interesting. I assume you use Windows? In principle there is no reason to discriminate based on any operating system... But in practice having any part of the build chain using windows BAT files is not going to work, as none of the existing developers could do anything with it. Are you able to use the Windows Subsystem for Linux? (Despite its name, it really is Linux compatible packages for Windows...) Could you write this same file in SHELL or BASH? Alternatively you could write this as a python script. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
