This is an automated email from the ASF dual-hosted git repository.
adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new 018d9d9e8f HDDS-9513. Fix gRPC queue time metrics and quantiles (#5480)
018d9d9e8f is described below
commit 018d9d9e8f8ea6db933a13c95a1243d4b0a64af5
Author: WangYuanben <[email protected]>
AuthorDate: Wed Oct 25 19:52:56 2023 +0800
HDDS-9513. Fix gRPC queue time metrics and quantiles (#5480)
---
.../org/apache/hadoop/ozone/grpc/metrics/GrpcMetrics.java | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git
a/hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/grpc/metrics/GrpcMetrics.java
b/hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/grpc/metrics/GrpcMetrics.java
index 3b2f7b5555..23c3dbaf15 100644
---
a/hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/grpc/metrics/GrpcMetrics.java
+++
b/hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/grpc/metrics/GrpcMetrics.java
@@ -71,7 +71,7 @@ public class GrpcMetrics implements MetricsSource {
new MutableQuantiles[intervals.length];
for (int i = 0; i < intervals.length; i++) {
int interval = intervals[i];
- grpcProcessingTimeMillisQuantiles[i] = registry
+ grpcQueueTimeMillisQuantiles[i] = registry
.newQuantiles("grpcQueueTime" + interval
+ "s", "grpc queue time in millisecond", "ops",
"latency", interval);
@@ -104,18 +104,9 @@ public class GrpcMetrics implements MetricsSource {
@Override
public synchronized void getMetrics(MetricsCollector collector, boolean all)
{
+ registry.snapshot(collector.addRecord(registry.info()), all);
MetricsRecordBuilder recordBuilder = collector.addRecord(SOURCE_NAME);
-
recordBuilder.tag(LATEST_REQUEST_TYPE, requestType);
-
- sentBytes.snapshot(recordBuilder, all);
- receivedBytes.snapshot(recordBuilder, all);
- unknownMessagesSent.snapshot(recordBuilder, all);
- unknownMessagesReceived.snapshot(recordBuilder, all);
- grpcQueueTime.snapshot(recordBuilder, all);
- grpcProcessingTime.snapshot(recordBuilder, all);
- numOpenClientConnections.snapshot(recordBuilder, all);
- recordBuilder.endRecord();
}
@Metric("Number of sent bytes")
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
