This is an automated email from the ASF dual-hosted git repository.
hemant pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new 4cda788c7f HDDS-9986. Log if there is a failure in closing RocksDB
4cda788c7f is described below
commit 4cda788c7f311e8cc90283a02c96f0734af79742
Author: Hemant Kumar <[email protected]>
AuthorDate: Thu Dec 21 22:08:38 2023 -0800
HDDS-9986. Log if there is a failure in closing RocksDB
---
.../src/main/java/org/apache/hadoop/hdds/utils/db/RDBStore.java | 4 ++--
.../main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotCache.java | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git
a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStore.java
b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStore.java
index 65e891f982..71cd3716e5 100644
---
a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStore.java
+++
b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStore.java
@@ -226,12 +226,12 @@ public class RDBStore implements DBStore {
}
RDBMetrics.unRegister();
- IOUtils.closeQuietly(checkPointManager);
+ IOUtils.close(LOG, checkPointManager);
if (rocksDBCheckpointDiffer != null) {
RocksDBCheckpointDifferHolder
.invalidateCacheEntry(rocksDBCheckpointDiffer.getMetadataDir());
}
- IOUtils.closeQuietly(db);
+ IOUtils.close(LOG, db);
}
@Override
diff --git
a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotCache.java
b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotCache.java
index 97a7a0608d..d8932c0e7e 100644
---
a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotCache.java
+++
b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotCache.java
@@ -169,8 +169,8 @@ public class SnapshotCache implements
ReferenceCountedCallback {
// does not exist, and increment the reference count on the instance.
ReferenceCounted<IOmMetadataReader, SnapshotCache> rcOmSnapshot =
dbMap.compute(key, (k, v) -> {
- LOG.info("Loading snapshot. Table key: {}", k);
if (v == null) {
+ LOG.info("Loading snapshot. Table key: {}", k);
try {
v = new ReferenceCounted<>(cacheLoader.load(k), false, this);
} catch (OMException omEx) {
@@ -317,7 +317,7 @@ public class SnapshotCache implements
ReferenceCountedCallback {
Preconditions.checkState(rcOmSnapshot == result,
"Cache map entry removal failure. The cache is in an inconsistent "
+ "state. Expected OmSnapshot instance: " + rcOmSnapshot
- + ", actual: " + result);
+ + ", actual: " + result + " for key: " + key);
pendingEvictionList.remove(result);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
