This is an automated email from the ASF dual-hosted git repository.
sshenoy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new db1561ac10 HDDS-10385. Memory leak for thread local usages in
OMClientRequest. (#6234)
db1561ac10 is described below
commit db1561ac107536601e2d58ae4fd980d6447b3b0b
Author: Sumit Agrawal <[email protected]>
AuthorDate: Wed Feb 21 11:47:06 2024 +0530
HDDS-10385. Memory leak for thread local usages in OMClientRequest. (#6234)
---
.../java/org/apache/hadoop/ozone/om/request/OMClientRequest.java | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java
b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java
index d0dd2caa54..6c8a66ee7e 100644
---
a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java
+++
b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java
@@ -78,8 +78,7 @@ public abstract class OMClientRequest implements
RequestAuditor {
private UserGroupInformation userGroupInformation;
private InetAddress inetAddress;
- private final ThreadLocal<OMLockDetails> omLockDetails =
- ThreadLocal.withInitial(OMLockDetails::new);
+ private final OMLockDetails omLockDetails = new OMLockDetails();
/**
* Stores the result of request execution in
@@ -94,7 +93,7 @@ public abstract class OMClientRequest implements
RequestAuditor {
public OMClientRequest(OMRequest omRequest) {
Preconditions.checkNotNull(omRequest);
this.omRequest = omRequest;
- this.omLockDetails.get().clear();
+ this.omLockDetails.clear();
}
/**
* Perform pre-execute steps on a OMRequest.
@@ -575,10 +574,10 @@ public abstract class OMClientRequest implements
RequestAuditor {
}
public OMLockDetails getOmLockDetails() {
- return omLockDetails.get();
+ return omLockDetails;
}
public void mergeOmLockDetails(OMLockDetails details) {
- omLockDetails.get().merge(details);
+ omLockDetails.merge(details);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
