This is an automated email from the ASF dual-hosted git repository.
adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new cc801988596 HDDS-14848. OzoneManagerSyncMetrics
incrNumDeltaRequestsFailed increments the wrong value (#9936)
cc801988596 is described below
commit cc8019885960746a3e2ee244f9f6fcb7530800d4
Author: Chun-Hung Tseng <[email protected]>
AuthorDate: Wed Mar 18 17:23:04 2026 +0900
HDDS-14848. OzoneManagerSyncMetrics incrNumDeltaRequestsFailed increments
the wrong value (#9936)
---
.../recon/metrics/OzoneManagerSyncMetrics.java | 2 +-
.../recon/metrics/TestOzoneManagerSyncMetrics.java | 50 ++++++++++++++++++++++
2 files changed, 51 insertions(+), 1 deletion(-)
diff --git
a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/metrics/OzoneManagerSyncMetrics.java
b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/metrics/OzoneManagerSyncMetrics.java
index dced0d0e63d..30f7e008d87 100644
---
a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/metrics/OzoneManagerSyncMetrics.java
+++
b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/metrics/OzoneManagerSyncMetrics.java
@@ -83,7 +83,7 @@ public void incrNumSnapshotRequestsFailed() {
}
public void incrNumDeltaRequestsFailed() {
- this.numSnapshotRequestsFailed.incr();
+ this.numDeltaRequestsFailed.incr();
}
public void incrNumUpdatesInDeltaTotal(long n) {
diff --git
a/hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/metrics/TestOzoneManagerSyncMetrics.java
b/hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/metrics/TestOzoneManagerSyncMetrics.java
new file mode 100644
index 00000000000..a81adce41ac
--- /dev/null
+++
b/hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/metrics/TestOzoneManagerSyncMetrics.java
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.recon.metrics;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import org.junit.jupiter.api.Test;
+
+/**
+ * Tests {@link OzoneManagerSyncMetrics}.
+ */
+public class TestOzoneManagerSyncMetrics {
+
+ @Test
+ void testDeltaFailuresIncrementIndependentCounter() {
+ OzoneManagerSyncMetrics metrics = OzoneManagerSyncMetrics.create();
+ try {
+ metrics.incrNumSnapshotRequests();
+ metrics.incrNumSnapshotRequestsFailed();
+ metrics.incrNumDeltaRequestsFailed();
+ metrics.incrNumUpdatesInDeltaTotal(7);
+ metrics.setSequenceNumberLag(11);
+
+ assertEquals(1, metrics.getNumSnapshotRequests());
+ assertEquals(1, metrics.getNumSnapshotRequestsFailed());
+ assertEquals(1, metrics.getNumDeltaRequestsFailed());
+ assertEquals(7, metrics.getNumUpdatesInDeltaTotal());
+ assertEquals(1, metrics.getNumNonZeroDeltaRequests());
+ assertEquals(7.0f, metrics.getAverageNumUpdatesInDeltaRequest());
+ assertEquals(11, metrics.getSequenceNumberLag());
+ } finally {
+ metrics.unRegister();
+ }
+ }
+}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
