This is an automated email from the ASF dual-hosted git repository.

lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-paimon.git


The following commit(s) were added to refs/heads/master by this push:
     new d4390c311 [spark] add warning message when using InMemoryCatalog in 
SparkGenericCatalog (#1463)
d4390c311 is described below

commit d4390c3117bbd4f9090e9479356dac6ad87790ff
Author: LsomeYeah <[email protected]>
AuthorDate: Wed Jul 5 20:38:28 2023 +0800

    [spark] add warning message when using InMemoryCatalog in 
SparkGenericCatalog (#1463)
---
 .../main/java/org/apache/paimon/spark/SparkGenericCatalog.java   | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git 
a/paimon-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/SparkGenericCatalog.java
 
b/paimon-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/SparkGenericCatalog.java
index 1f819dd03..59355af32 100644
--- 
a/paimon-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/SparkGenericCatalog.java
+++ 
b/paimon-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/SparkGenericCatalog.java
@@ -33,6 +33,7 @@ import 
org.apache.spark.sql.catalyst.analysis.NoSuchNamespaceException;
 import org.apache.spark.sql.catalyst.analysis.NoSuchTableException;
 import org.apache.spark.sql.catalyst.analysis.NonEmptyNamespaceException;
 import org.apache.spark.sql.catalyst.analysis.TableAlreadyExistsException;
+import org.apache.spark.sql.catalyst.catalog.InMemoryCatalog;
 import org.apache.spark.sql.connector.catalog.CatalogExtension;
 import org.apache.spark.sql.connector.catalog.CatalogPlugin;
 import org.apache.spark.sql.connector.catalog.Identifier;
@@ -45,6 +46,8 @@ import 
org.apache.spark.sql.connector.catalog.functions.UnboundFunction;
 import org.apache.spark.sql.connector.expressions.Transform;
 import org.apache.spark.sql.types.StructType;
 import org.apache.spark.sql.util.CaseInsensitiveStringMap;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.util.HashMap;
 import java.util.Map;
@@ -63,6 +66,8 @@ import static 
org.apache.paimon.utils.Preconditions.checkNotNull;
 public class SparkGenericCatalog<T extends TableCatalog & SupportsNamespaces>
         implements CatalogExtension {
 
+    private static final Logger LOG = 
LoggerFactory.getLogger(SparkGenericCatalog.class);
+
     private static final String[] DEFAULT_NAMESPACE = new String[] {"default"};
 
     private String catalogName = null;
@@ -216,6 +221,10 @@ public class SparkGenericCatalog<T extends TableCatalog & 
SupportsNamespaces>
                 }
             }
         }
+        if (SparkSession.active().sharedState().externalCatalog().unwrapped()
+                instanceof InMemoryCatalog) {
+            LOG.warn("InMemoryCatalog here may cause bad effect.");
+        }
 
         this.catalogName = name;
         this.paimonCatalog = new SparkCatalog();

Reply via email to