(incubator-paimon-webui) branch main updated: [Bugfix] Fix NullPointerException for list tables interface without table name (#105)

[nicholasjiang]

This is an automated email from the ASF dual-hosted git repository.

nicholasjiang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-paimon-webui.git


The following commit(s) were added to refs/heads/main by this push:
     new 8a13fb9  [Bugfix] Fix NullPointerException for list tables interface 
without table name (#105)
8a13fb9 is described below

commit 8a13fb98e5461d6eec9e2caab1cf1eea28891ddc
Author: Hunter <53144338+hunter-clou...@users.noreply.github.com>
AuthorDate: Wed Dec 6 19:56:03 2023 +0800

    [Bugfix] Fix NullPointerException for list tables interface without table 
name (#105)
---
 .../org/apache/paimon/web/server/service/impl/TableServiceImpl.java  | 5 +++--
 .../org/apache/paimon/web/server/controller/TableControllerTest.java | 5 ++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/paimon-web-server/src/main/java/org/apache/paimon/web/server/service/impl/TableServiceImpl.java
 
b/paimon-web-server/src/main/java/org/apache/paimon/web/server/service/impl/TableServiceImpl.java
index 6e43e7d..a871fa3 100644
--- 
a/paimon-web-server/src/main/java/org/apache/paimon/web/server/service/impl/TableServiceImpl.java
+++ 
b/paimon-web-server/src/main/java/org/apache/paimon/web/server/service/impl/TableServiceImpl.java
@@ -287,11 +287,12 @@ public class TableServiceImpl implements TableService {
                             table.setCatalogId(catalog.getId());
                             table.setCatalogName(catalog.getCatalogName());
                             table.setName(name);
-                            table.setDatabaseName(table.getDatabaseName());
+                            table.setDatabaseName(tableDTO.getDatabaseName());
                             resultList.add(table);
                         });
                 break;
-            } else {
+            }
+            if (Objects.nonNull(tableDTO.getName())) {
                 paimonService = PaimonServiceUtils.getPaimonService(catalog);
                 List<String> databaseList = paimonService.listDatabases();
                 for (String database : databaseList) {
diff --git 
a/paimon-web-server/src/test/java/org/apache/paimon/web/server/controller/TableControllerTest.java
 
b/paimon-web-server/src/test/java/org/apache/paimon/web/server/controller/TableControllerTest.java
index 359300e..0bf1830 100644
--- 
a/paimon-web-server/src/test/java/org/apache/paimon/web/server/controller/TableControllerTest.java
+++ 
b/paimon-web-server/src/test/java/org/apache/paimon/web/server/controller/TableControllerTest.java
@@ -307,9 +307,8 @@ public class TableControllerTest extends ControllerTestBase 
{
     @Test
     public void testListTables() throws Exception {
         TableDTO table = new TableDTO();
-        table.setName(tableName);
-        //        table.setCatalogId(catalogId);
-        //        table.setDatabaseName(databaseName);
+        table.setCatalogId(catalogId);
+        table.setDatabaseName(databaseName);
         String responseString =
                 mockMvc.perform(
                                 MockMvcRequestBuilders.post(tablePath + 
"/list")