This is an automated email from the ASF dual-hosted git repository. lzljs3620320 pushed a commit to branch release-1.0 in repository https://gitbox.apache.org/repos/asf/paimon.git
commit 4bf624e52a6cadb866e3eade2ce8580ef03c2977 Author: yuzelin <[email protected]> AuthorDate: Tue Jan 21 10:21:59 2025 +0800 [hotfix] remove_orphan_files action shouldn't check table argument (table=null means clean whole database) (#4961) --- .../paimon/flink/action/RemoveOrphanFilesActionFactory.java | 2 +- .../paimon/flink/action/RemoveOrphanFilesActionITCaseBase.java | 10 +++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/RemoveOrphanFilesActionFactory.java b/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/RemoveOrphanFilesActionFactory.java index 279bc87baf..9db1b7263a 100644 --- a/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/RemoveOrphanFilesActionFactory.java +++ b/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/RemoveOrphanFilesActionFactory.java @@ -38,7 +38,7 @@ public class RemoveOrphanFilesActionFactory implements ActionFactory { RemoveOrphanFilesAction action = new RemoveOrphanFilesAction( params.getRequired(DATABASE), - params.getRequired(TABLE), + params.get(TABLE), params.get(PARALLELISM), catalogConfigMap(params)); diff --git a/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/action/RemoveOrphanFilesActionITCaseBase.java b/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/action/RemoveOrphanFilesActionITCaseBase.java index 2828101114..8d56fa93dc 100644 --- a/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/action/RemoveOrphanFilesActionITCaseBase.java +++ b/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/action/RemoveOrphanFilesActionITCaseBase.java @@ -170,9 +170,13 @@ public abstract class RemoveOrphanFilesActionITCaseBase extends ActionITCaseBase "--warehouse", warehouse, "--database", - database, - "--table", - "*")); + database)); + + if (ThreadLocalRandom.current().nextBoolean()) { + args.add("--table"); + args.add("*"); + } + RemoveOrphanFilesAction action1 = createAction(RemoveOrphanFilesAction.class, args); assertThatCode(action1::run).doesNotThrowAnyException();
