This is an automated email from the ASF dual-hosted git repository.
lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/paimon.git
The following commit(s) were added to refs/heads/master by this push:
new 5db324d357 [core] Remove useless close in SstFileWriter
5db324d357 is described below
commit 5db324d3573f6cf0f4128ba6380ef72569d967d4
Author: JingsongLi <[email protected]>
AuthorDate: Thu Dec 25 22:02:13 2025 +0800
[core] Remove useless close in SstFileWriter
---
.../java/org/apache/paimon/sst/SstFileWriter.java | 33 ----------------------
1 file changed, 33 deletions(-)
diff --git
a/paimon-common/src/main/java/org/apache/paimon/sst/SstFileWriter.java
b/paimon-common/src/main/java/org/apache/paimon/sst/SstFileWriter.java
index 1a8e2d8bda..1f1405671b 100644
--- a/paimon-common/src/main/java/org/apache/paimon/sst/SstFileWriter.java
+++ b/paimon-common/src/main/java/org/apache/paimon/sst/SstFileWriter.java
@@ -22,7 +22,6 @@ import org.apache.paimon.compression.BlockCompressionFactory;
import org.apache.paimon.compression.BlockCompressionType;
import org.apache.paimon.compression.BlockCompressor;
import org.apache.paimon.fs.PositionOutputStream;
-import org.apache.paimon.lookup.sort.SortLookupStoreFooter;
import org.apache.paimon.memory.MemorySegment;
import org.apache.paimon.memory.MemorySlice;
import org.apache.paimon.options.MemorySize;
@@ -191,38 +190,6 @@ public class SstFileWriter {
return indexBlock;
}
- public void close() throws IOException {
- // flush current data block
- flush();
-
- LOG.info("Number of record: {}", recordCount);
-
- // write bloom filter
- @Nullable BloomFilterHandle bloomFilterHandle = null;
- if (bloomFilter != null) {
- MemorySegment buffer = bloomFilter.getBuffer();
- bloomFilterHandle =
- new BloomFilterHandle(
- out.getPos(), buffer.size(),
bloomFilter.expectedEntries());
- writeSlice(MemorySlice.wrap(buffer));
- LOG.info("Bloom filter size: {} bytes",
bloomFilter.getBuffer().size());
- }
-
- // write index block
- BlockHandle indexBlockHandle = writeBlock(indexBlockWriter);
-
- // write footer
- SortLookupStoreFooter footer =
- new SortLookupStoreFooter(bloomFilterHandle, indexBlockHandle);
- MemorySlice footerEncoding = SortLookupStoreFooter.writeFooter(footer);
- writeSlice(footerEncoding);
-
- // do not need to close outputStream, since it will be closed by outer
classes
-
- LOG.info("totalUncompressedSize: {}",
MemorySize.ofBytes(totalUncompressedSize));
- LOG.info("totalCompressedSize: {}",
MemorySize.ofBytes(totalCompressedSize));
- }
-
public void writeSlice(MemorySlice slice) throws IOException {
out.write(slice.getHeapMemory(), slice.offset(), slice.length());
}