This is an automated email from the ASF dual-hosted git repository.

lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/paimon.git


The following commit(s) were added to refs/heads/master by this push:
     new 1523ecb85f [core] Minor refactor to magic number into footer
1523ecb85f is described below

commit 1523ecb85fc08484d4a9fbe9b877261685e3d12f
Author: JingsongLi <[email protected]>
AuthorDate: Fri Dec 26 21:50:47 2025 +0800

    [core] Minor refactor to magic number into footer
---
 .../main/java/org/apache/paimon/globalindex/btree/BTreeFileFooter.java | 3 ++-
 .../org/apache/paimon/globalindex/btree/BTreeFileMetaSelector.java     | 1 +
 .../org/apache/paimon/globalindex/btree/BTreeGlobalIndexerFactory.java | 1 +
 .../main/java/org/apache/paimon/globalindex/btree/BTreeIndexMeta.java  | 1 +
 .../java/org/apache/paimon/globalindex/btree/BTreeIndexOptions.java    | 1 +
 .../java/org/apache/paimon/globalindex/btree/BTreeIndexReader.java     | 1 +
 .../java/org/apache/paimon/globalindex/btree/BTreeIndexWriter.java     | 1 -
 .../main/java/org/apache/paimon/lookup/sort/SortLookupStoreFooter.java | 2 +-
 .../main/java/org/apache/paimon/lookup/sort/SortLookupStoreWriter.java | 1 -
 9 files changed, 8 insertions(+), 4 deletions(-)

diff --git 
a/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeFileFooter.java
 
b/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeFileFooter.java
index 1484e12cea..84293fd127 100644
--- 
a/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeFileFooter.java
+++ 
b/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeFileFooter.java
@@ -26,11 +26,12 @@ import org.apache.paimon.sst.BloomFilterHandle;
 
 import javax.annotation.Nullable;
 
-import static 
org.apache.paimon.globalindex.btree.BTreeIndexWriter.MAGIC_NUMBER;
 import static org.apache.paimon.utils.Preconditions.checkArgument;
 
 /** The Footer for BTree file. */
 public class BTreeFileFooter {
+
+    public static final int MAGIC_NUMBER = 198732882;
     public static final int ENCODED_LENGTH = 48;
 
     @Nullable private final BloomFilterHandle bloomFilterHandle;
diff --git 
a/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeFileMetaSelector.java
 
b/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeFileMetaSelector.java
index 06846eec3e..334771e125 100644
--- 
a/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeFileMetaSelector.java
+++ 
b/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeFileMetaSelector.java
@@ -39,6 +39,7 @@ import java.util.stream.Collectors;
  * Please do not break this premise if you want to implement your own index 
scanner.
  */
 public class BTreeFileMetaSelector implements 
FunctionVisitor<Optional<List<GlobalIndexIOMeta>>> {
+
     private final List<Pair<GlobalIndexIOMeta, BTreeIndexMeta>> files;
     private final Comparator<Object> comparator;
     private final KeySerializer keySerializer;
diff --git 
a/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeGlobalIndexerFactory.java
 
b/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeGlobalIndexerFactory.java
index 914ed2a467..2ec929cab7 100644
--- 
a/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeGlobalIndexerFactory.java
+++ 
b/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeGlobalIndexerFactory.java
@@ -25,6 +25,7 @@ import org.apache.paimon.types.DataField;
 
 /** The {@link GlobalIndexerFactory} for btree index. */
 public class BTreeGlobalIndexerFactory implements GlobalIndexerFactory {
+
     public static final String IDENTIFIER = "btree";
 
     @Override
diff --git 
a/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeIndexMeta.java
 
b/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeIndexMeta.java
index da4a1be622..c134f1fa1e 100644
--- 
a/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeIndexMeta.java
+++ 
b/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeIndexMeta.java
@@ -24,6 +24,7 @@ import org.apache.paimon.memory.MemorySliceOutput;
 
 /** Index Meta of each BTree index file. */
 public class BTreeIndexMeta {
+
     private final byte[] firstKey;
     private final byte[] lastKey;
     private final boolean hasNulls;
diff --git 
a/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeIndexOptions.java
 
b/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeIndexOptions.java
index 687a3f380b..acac020db3 100644
--- 
a/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeIndexOptions.java
+++ 
b/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeIndexOptions.java
@@ -24,6 +24,7 @@ import org.apache.paimon.options.MemorySize;
 
 /** Options for BTree index. */
 public class BTreeIndexOptions {
+
     public static final ConfigOption<String> BTREE_INDEX_COMPRESSION =
             ConfigOptions.key("btree-index.compression")
                     .stringType()
diff --git 
a/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeIndexReader.java
 
b/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeIndexReader.java
index 59b6fe3c7b..dc0fba2175 100644
--- 
a/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeIndexReader.java
+++ 
b/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeIndexReader.java
@@ -48,6 +48,7 @@ import java.util.zip.CRC32;
 
 /** The {@link GlobalIndexReader} implementation for btree index. */
 public class BTreeIndexReader implements GlobalIndexReader {
+
     private final SeekableInputStream input;
     private final SstFileReader reader;
     private final KeySerializer keySerializer;
diff --git 
a/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeIndexWriter.java
 
b/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeIndexWriter.java
index 69b62290dd..97c5f6430a 100644
--- 
a/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeIndexWriter.java
+++ 
b/paimon-common/src/main/java/org/apache/paimon/globalindex/btree/BTreeIndexWriter.java
@@ -67,7 +67,6 @@ import java.util.zip.CRC32;
  * each key.
  */
 public class BTreeIndexWriter implements GlobalIndexWriter {
-    public static final int MAGIC_NUMBER = 198732882;
 
     private final String fileName;
     private final PositionOutputStream out;
diff --git 
a/paimon-common/src/main/java/org/apache/paimon/lookup/sort/SortLookupStoreFooter.java
 
b/paimon-common/src/main/java/org/apache/paimon/lookup/sort/SortLookupStoreFooter.java
index 5239bb133e..e714d12421 100644
--- 
a/paimon-common/src/main/java/org/apache/paimon/lookup/sort/SortLookupStoreFooter.java
+++ 
b/paimon-common/src/main/java/org/apache/paimon/lookup/sort/SortLookupStoreFooter.java
@@ -26,12 +26,12 @@ import org.apache.paimon.sst.BloomFilterHandle;
 
 import javax.annotation.Nullable;
 
-import static org.apache.paimon.lookup.sort.SortLookupStoreWriter.MAGIC_NUMBER;
 import static org.apache.paimon.utils.Preconditions.checkArgument;
 
 /** Footer for a sorted file. */
 public class SortLookupStoreFooter {
 
+    public static final int MAGIC_NUMBER = 1481571681;
     public static final int ENCODED_LENGTH = 36;
 
     @Nullable private final BloomFilterHandle bloomFilterHandle;
diff --git 
a/paimon-common/src/main/java/org/apache/paimon/lookup/sort/SortLookupStoreWriter.java
 
b/paimon-common/src/main/java/org/apache/paimon/lookup/sort/SortLookupStoreWriter.java
index c652c90e82..e5fab5fc5c 100644
--- 
a/paimon-common/src/main/java/org/apache/paimon/lookup/sort/SortLookupStoreWriter.java
+++ 
b/paimon-common/src/main/java/org/apache/paimon/lookup/sort/SortLookupStoreWriter.java
@@ -52,7 +52,6 @@ import java.io.IOException;
  * </pre>
  */
 public class SortLookupStoreWriter implements LookupStoreWriter {
-    public static final int MAGIC_NUMBER = 1481571681;
 
     private final SstFileWriter writer;
     private final PositionOutputStream out;

Reply via email to