(paimon) branch master updated: [core] Minor refactor arguements for FileStoreCommitImpl

[lzljs3620320]

This is an automated email from the ASF dual-hosted git repository.

lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/paimon.git


The following commit(s) were added to refs/heads/master by this push:
     new ce3d7192d4 [core] Minor refactor arguements for FileStoreCommitImpl
ce3d7192d4 is described below

commit ce3d7192d4375dd350800a864a5c22ca1a66c6b4
Author: JingsongLi <jingsongl...@gmail.com>
AuthorDate: Thu Feb 5 13:42:38 2026 +0800

    [core] Minor refactor arguements for FileStoreCommitImpl
---
 .../java/org/apache/paimon/AbstractFileStore.java   | 21 ++++++++++-----------
 .../paimon/operation/FileStoreCommitImpl.java       |  9 ++++-----
 2 files changed, 14 insertions(+), 16 deletions(-)

diff --git a/paimon-core/src/main/java/org/apache/paimon/AbstractFileStore.java 
b/paimon-core/src/main/java/org/apache/paimon/AbstractFileStore.java
index a92bde3d64..8b30113f02 100644
--- a/paimon-core/src/main/java/org/apache/paimon/AbstractFileStore.java
+++ b/paimon-core/src/main/java/org/apache/paimon/AbstractFileStore.java
@@ -326,6 +326,7 @@ abstract class AbstractFileStore<T> implements FileStore<T> 
{
                 newStatsFileHandler(),
                 bucketMode(),
                 options.scanManifestParallelism(),
+                createCommitPreCallbacks(table),
                 createCommitCallbacks(commitUser, table),
                 options.commitMaxRetries(),
                 options.commitTimeout(),
@@ -335,8 +336,7 @@ abstract class AbstractFileStore<T> implements FileStore<T> 
{
                 options.commitDiscardDuplicateFiles(),
                 conflictDetectFactory,
                 strictModeChecker,
-                rollback,
-                createCommitPreCallbacks(commitUser, table));
+                rollback);
     }
 
     @Override
@@ -395,6 +395,14 @@ abstract class AbstractFileStore<T> implements 
FileStore<T> {
                 options.legacyPartitionName());
     }
 
+    private List<CommitPreCallback> createCommitPreCallbacks(FileStoreTable 
table) {
+        List<CommitPreCallback> callbacks = new ArrayList<>();
+        if (options.isChainTable()) {
+            callbacks.add(new ChainTableCommitPreCallback(table));
+        }
+        return callbacks;
+    }
+
     private List<CommitCallback> createCommitCallbacks(String commitUser, 
FileStoreTable table) {
         List<CommitCallback> callbacks = new ArrayList<>();
 
@@ -434,15 +442,6 @@ abstract class AbstractFileStore<T> implements 
FileStore<T> {
         return callbacks;
     }
 
-    private List<CommitPreCallback> createCommitPreCallbacks(
-            String commitUser, FileStoreTable table) {
-        List<CommitPreCallback> callbacks = new ArrayList<>();
-        if (options.isChainTable()) {
-            callbacks.add(new ChainTableCommitPreCallback(table));
-        }
-        return callbacks;
-    }
-
     @Override
     @Nullable
     public PartitionExpire newPartitionExpire(String commitUser, 
FileStoreTable table) {
diff --git 
a/paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
 
b/paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
index 32a184ea4d..983f541446 100644
--- 
a/paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
+++ 
b/paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
@@ -150,6 +150,7 @@ public class FileStoreCommitImpl implements FileStoreCommit 
{
     private final boolean dynamicPartitionOverwrite;
     private final String branchName;
     @Nullable private final Integer manifestReadParallelism;
+    private final List<CommitPreCallback> commitPreCallbacks;
     private final List<CommitCallback> commitCallbacks;
     private final StatsFileHandler statsFileHandler;
     private final BucketMode bucketMode;
@@ -167,8 +168,6 @@ public class FileStoreCommitImpl implements FileStoreCommit 
{
     private CommitMetrics commitMetrics;
     private boolean appendCommitCheckConflict = false;
 
-    private final List<CommitPreCallback> commitPreCallbacks;
-
     public FileStoreCommitImpl(
             SnapshotCommit snapshotCommit,
             FileIO fileIO,
@@ -193,6 +192,7 @@ public class FileStoreCommitImpl implements FileStoreCommit 
{
             StatsFileHandler statsFileHandler,
             BucketMode bucketMode,
             @Nullable Integer manifestReadParallelism,
+            List<CommitPreCallback> commitPreCallbacks,
             List<CommitCallback> commitCallbacks,
             int commitMaxRetries,
             long commitTimeout,
@@ -202,8 +202,7 @@ public class FileStoreCommitImpl implements FileStoreCommit 
{
             boolean discardDuplicateFiles,
             ConflictDetection.Factory conflictDetectFactory,
             @Nullable StrictModeChecker strictModeChecker,
-            @Nullable CommitRollback rollback,
-            List<CommitPreCallback> commitPreCallbacks) {
+            @Nullable CommitRollback rollback) {
         this.snapshotCommit = snapshotCommit;
         this.fileIO = fileIO;
         this.schemaManager = schemaManager;
@@ -226,6 +225,7 @@ public class FileStoreCommitImpl implements FileStoreCommit 
{
         this.dynamicPartitionOverwrite = dynamicPartitionOverwrite;
         this.branchName = branchName;
         this.manifestReadParallelism = manifestReadParallelism;
+        this.commitPreCallbacks = commitPreCallbacks;
         this.commitCallbacks = commitCallbacks;
         this.commitMaxRetries = commitMaxRetries;
         this.commitTimeout = commitTimeout;
@@ -245,7 +245,6 @@ public class FileStoreCommitImpl implements FileStoreCommit 
{
         this.strictModeChecker = strictModeChecker;
         this.conflictDetection = conflictDetectFactory.create(scanner);
         this.commitCleaner = new CommitCleaner(manifestList, manifestFile, 
indexManifestFile);
-        this.commitPreCallbacks = commitPreCallbacks;
     }
 
     @Override