Fokko commented on code in PR #76: URL: https://github.com/apache/parquet-site/pull/76#discussion_r1696609221
########## content/en/docs/Contribution Guidelines/contributing.md: ########## @@ -9,97 +9,59 @@ description: > Pull Requests ------------- -We prefer to receive contributions in the form of GitHub pull requests. Please send pull requests against the [github.com/apache/parquet-mr](https://github.com/apache/parquet-mr) repository. If you’ve previously forked Parquet from its old location, you will need to add a remote or update your origin remote to [https://github.com/apache/parquet-mr.git](https://github.com/apache/parquet-mr.git) Here are a few tips to get your contribution in: +We prefer to receive contributions in the form of GitHub pull requests. Please send pull requests against the [github.com/apache/parquet-java](https://github.com/apache/parquet-java) repository. If you’ve previously forked Parquet from its old location, you will need to add a remote or update your origin remote to [https://github.com/apache/parquet-java.git](https://github.com/apache/parquet-java.git). Here are a few tips to get your contribution in: 1. Break your work into small, single-purpose patches if possible. It’s much harder to merge in a large change with a lot of disjoint features. -2. Create a JIRA for your patch on the [Parquet Project JIRA](https://issues.apache.org/jira/browse/PARQUET). -3. Submit the patch as a GitHub pull request against the master branch. For a tutorial, see the GitHub guides on forking a repo and sending a pull request. Prefix your pull request name with the JIRA name (ex: [https://github.com/apache/parquet-mr/pull/5](https://github.com/apache/parquet-mr/pull/5)). +2. Create an Issue on the [Parquet-Java issues](https://github.com/apache/parquet-java/issues). +3. Submit the patch as a GitHub pull request against the master branch. For a tutorial, see the GitHub guides on forking a repo and sending a pull request. Prefix your pull request name with the Issue `GH-2935`: (ex: [https://github.com/apache/parquet-java/pull/2951](https://github.com/apache/parquet-java/pull/2951)). 4. Make sure that your code passes the unit tests. You can run the tests with `mvn test` in the root directory. 5. Add new unit tests for your code. -6. All Pull Requests are tested automatically on [GitHub Actions](https://github.com/apache/parquet-mr/actions). [TravisCI](https://travis-ci.org/github/apache/parquet-mr) is also used to run the tests on ARM64 CPU architecture +6. All Pull Requests are tested automatically on [GitHub Actions](https://github.com/apache/parquet-mr/actions). -If you’d like to report a bug but don’t have time to fix it, you can still post it to our [issue tracker](https://issues.apache.org/jira/browse/PARQUET), or email the mailing list ([d...@parquet.apache.org](mailto:d...@parquet.apache.org)). +If you’d like to report a bug but don’t have time to fix it, you can still [raise an issue](https://github.com/apache/parquet-java/issues), or email the mailing list ([d...@parquet.apache.org](mailto:d...@parquet.apache.org)). Committers ---------- -Merging a pull request requires being a committer on the project. - -How to merge a Pull request (have an apache and github-apache remote setup): - - git remote add github-apache g...@github.com:apache/parquet-mr.git - git remote add apache https://gitbox.apache.org/repos/asf?p=parquet-mr.git - - -run the following command - - dev/merge_parquet_pr.py - - -example output: - - Which pull request would you like to merge? (e.g. 34): +### Merging a Pull Request +Merging a pull request requires being a committer on the project. Review Comment: Since we're already doing that, I think it is good to formalize that as well 👍 Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
