This is an automated email from the ASF dual-hosted git repository.
wgtmac pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-java.git
The following commit(s) were added to refs/heads/master by this push:
new 09bd18683 MINOR: Fix withLogicalTypeAnnotation Javadoc @return
description (#3648)
09bd18683 is described below
commit 09bd18683120cc503f4b1dd4f3cab57a8256146a
Author: Anas Khan <[email protected]>
AuthorDate: Tue Jul 14 14:35:35 2026 +0530
MINOR: Fix withLogicalTypeAnnotation Javadoc @return description (#3648)
The @return tag on PrimitiveType.withLogicalTypeAnnotation read
"a new PrimitiveType with the same fields and a new id null", which was a
mangled copy-paste from the sibling withId(int) method. The method does not
assign a new id: it returns a copy carrying the given logical type
annotation
while preserving the existing id via getId(). Correct the description to
match
the actual behavior.
Signed-off-by: Anas Khan <[email protected]>
---
.../src/main/java/org/apache/parquet/schema/PrimitiveType.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveType.java
b/parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveType.java
index 81f2781cd..c3766fa15 100644
--- a/parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveType.java
+++ b/parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveType.java
@@ -678,7 +678,7 @@ public final class PrimitiveType extends Type {
/**
* @param logicalType LogicalTypeAnnotation
- * @return a new PrimitiveType with the same fields and a new id null
+ * @return a new PrimitiveType with the same fields and the given logical
type annotation
*/
public PrimitiveType withLogicalTypeAnnotation(LogicalTypeAnnotation
logicalType) {
return new PrimitiveType(getRepetition(), primitive, length, getName(),
logicalType, getId());
