steveloughran commented on PR #190: URL: https://github.com/apache/parquet-site/pull/190#issuecomment-4992311538
@nastra > my guess is because they realized that it's more natural to mentally define actual and then expected. I've also seen numerous cases across the parquet-java codebase where the actual/expected were flipped, which is easy to do JUnit assertions yeah, maybe they looked at use and conclude that actually the majority of real-world uses had expected and actual mixed up. Certainly that was true in about 90% of PRs I've ever reviewed from people who weren't experienced with using junit for many years and knew of this quirk from time debugging its error messages. After all, when the asserts work, you never realise that the ordering matters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
