svn commit: r1887904 - /pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFEncoding.java

[lehmi]

Author: lehmi
Date: Sun Mar 21 17:07:03 2021
New Revision: 1887904

URL: http://svn.apache.org/viewvc?rev=1887904&view=rev
Log:
PDFBOX-4892: remove redundant map and duplicated code

Modified:
    pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFEncoding.java

Modified: 
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFEncoding.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFEncoding.java?rev=1887904&r1=1887903&r2=1887904&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFEncoding.java 
(original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFEncoding.java 
Sun Mar 21 17:07:03 2021
@@ -18,9 +18,6 @@ package org.apache.fontbox.cff;
 
 import org.apache.fontbox.encoding.Encoding;
 
-import java.util.HashMap;
-import java.util.Map;
-
 /**
  * A CFF Type 1-equivalent Encoding. An encoding is an array of codes 
associated with some or all
  * glyphs in a font
@@ -29,8 +26,6 @@ import java.util.Map;
  */
 public abstract class CFFEncoding extends Encoding
 {
-    private final Map<Integer, String> codeToName = new HashMap<>(250);
-
     /**
      * Package-private constructor for subclasses.
      */
@@ -39,30 +34,12 @@ public abstract class CFFEncoding extend
     }
 
     /**
-     * Returns the name of the glyph for the given character code.
-     *
-     * @param code character code
-     * @return PostScript glyph name
-     */
-    @Override
-    public String getName(int code)
-    {
-        String name = codeToName.get(code);
-        if (name == null)
-        {
-            return ".notdef";
-        }
-        return name;
-    }
-
-    /**
      * Adds a new code/SID combination to the encoding.
      * @param code the given code
      * @param sid the given SID
      */
     public void add(int code, int sid, String name)
     {
-        codeToName.put(code, name);
         addCharacterEncoding(code, name);
     }
 
@@ -71,8 +48,6 @@ public abstract class CFFEncoding extend
      */
     protected void add(int code, int sid)
     {
-        String name = CFFStandardString.getName(sid);
-        codeToName.put(code, name);
-        addCharacterEncoding(code, name);
+        addCharacterEncoding(code, CFFStandardString.getName(sid));
     }
 }