Author: lehmi Date: Thu Sep 26 06:18:54 2024 New Revision: 1920945 URL: http://svn.apache.org/viewvc?rev=1920945&view=rev Log: PDFBOX-5852: don't create an unused array
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/ShadedTriangle.java Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/ShadedTriangle.java URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/ShadedTriangle.java?rev=1920945&r1=1920944&r2=1920945&view=diff ============================================================================== --- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/ShadedTriangle.java (original) +++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/ShadedTriangle.java Thu Sep 26 06:18:54 2024 @@ -232,11 +232,12 @@ class ShadedTriangle public float[] calcColor(Point2D p) { int numberOfColorComponents = color[0].length; - float[] pCol = new float[numberOfColorComponents]; + float[] pCol = null; switch (degree) { case 1: + pCol = new float[numberOfColorComponents]; for (int i = 0; i < numberOfColorComponents; i++) { // average @@ -246,8 +247,10 @@ class ShadedTriangle case 2: // linear interpolation Point tp = new Point((int) Math.round(p.getX()), (int) Math.round(p.getY())); - return line.calcColor(tp); + pCol = line.calcColor(tp); + break; default: + pCol = new float[numberOfColorComponents]; float aw = (float) (getArea(p, corner[1], corner[2]) / area); float bw = (float) (getArea(p, corner[2], corner[0]) / area); float cw = (float) (getArea(p, corner[0], corner[1]) / area);