svn commit: r1923379 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineNode.java

[tilman]

Author: tilman
Date: Sun Jan 26 15:50:39 2025
New Revision: 1923379

URL: http://svn.apache.org/viewvc?rev=1923379&view=rev
Log:
PDFBOX-5939: ignore outline that is its own parent

Modified:
    
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineNode.java

Modified: 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineNode.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineNode.java?rev=1923379&r1=1923378&r2=1923379&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineNode.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineNode.java
 Sun Jan 26 15:50:39 2025
@@ -16,6 +16,8 @@
  */
 package org.apache.pdfbox.pdmodel.interactive.documentnavigation.outline;
 
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 
 import org.apache.pdfbox.cos.COSDictionary;
 import org.apache.pdfbox.cos.COSName;
@@ -28,6 +30,7 @@ import org.apache.pdfbox.pdmodel.common.
  */
 public abstract class PDOutlineNode extends PDDictionaryWrapper
 {
+    private static final Logger LOG = 
LogManager.getLogger(PDOutlineNode.class);
 
     /**
      * Default Constructor.
@@ -283,6 +286,12 @@ public abstract class PDOutlineNode exte
         PDOutlineNode parent = getParent();
         if (parent != null)
         {
+            if (getCOSObject() == parent.getCOSObject())
+            {
+                // PDFBOX-5939
+                LOG.warn("Outline parent points to itself");
+                return;
+            }
             if (parent.isNodeOpen())
             {
                 parent.setOpenCount(parent.getOpenCount() + delta);