svn commit: r1924895 - in /pdfbox/branches/3.0: fontbox/src/test/java/org/apache/fontbox/ttf/GlyphSubstitutionTableTest.java pdfbox/src/test/java/org/apache/pdfbox/text/BidiTest.java pdfbox/src/test/java/org/apache/pdfbox/text/TestTextStripper.java

[tilman]

Author: tilman
Date: Mon Apr  7 10:17:24 2025
New Revision: 1924895

URL: http://svn.apache.org/viewvc?rev=1924895&view=rev
Log:
PDFBOX-5660: Sonar fix

Modified:
    
pdfbox/branches/3.0/fontbox/src/test/java/org/apache/fontbox/ttf/GlyphSubstitutionTableTest.java
    
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/text/BidiTest.java
    
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/text/TestTextStripper.java

Modified: 
pdfbox/branches/3.0/fontbox/src/test/java/org/apache/fontbox/ttf/GlyphSubstitutionTableTest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/branches/3.0/fontbox/src/test/java/org/apache/fontbox/ttf/GlyphSubstitutionTableTest.java?rev=1924895&r1=1924894&r2=1924895&view=diff
==============================================================================
--- 
pdfbox/branches/3.0/fontbox/src/test/java/org/apache/fontbox/ttf/GlyphSubstitutionTableTest.java
 (original)
+++ 
pdfbox/branches/3.0/fontbox/src/test/java/org/apache/fontbox/ttf/GlyphSubstitutionTableTest.java
 Mon Apr  7 10:17:24 2025
@@ -101,7 +101,7 @@ class GlyphSubstitutionTableTest
                     break;
                 }
 
-                if (line.trim().length() == 0)
+                if (line.trim().isEmpty())
                 {
                     continue;
                 }

Modified: 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/text/BidiTest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/text/BidiTest.java?rev=1924895&r1=1924894&r2=1924895&view=diff
==============================================================================
--- 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/text/BidiTest.java 
(original)
+++ 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/text/BidiTest.java 
Mon Apr  7 10:17:24 2025
@@ -153,12 +153,12 @@ class BidiTest
             while (true)
             {
                 String expectedLine = expectedReader.readLine();
-                while( expectedLine != null && expectedLine.trim().length() == 
0 )
+                while( expectedLine != null && expectedLine.trim().isEmpty())
                 {
                     expectedLine = expectedReader.readLine();
                 }
                 String actualLine = actualReader.readLine();
-                while( actualLine != null && actualLine.trim().length() == 0 )
+                while( actualLine != null && actualLine.trim().isEmpty())
                 {
                     actualLine = actualReader.readLine();
                 }

Modified: 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/text/TestTextStripper.java
URL: 
http://svn.apache.org/viewvc/pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/text/TestTextStripper.java?rev=1924895&r1=1924894&r2=1924895&view=diff
==============================================================================
--- 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/text/TestTextStripper.java
 (original)
+++ 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/text/TestTextStripper.java
 Mon Apr  7 10:17:24 2025
@@ -317,12 +317,12 @@ class TestTextStripper
             while (true)
             {
                 String expectedLine = expectedReader.readLine();
-                while( expectedLine != null && expectedLine.trim().length() == 
0 )
+                while (expectedLine != null && expectedLine.trim().isEmpty())
                 {
                     expectedLine = expectedReader.readLine();
                 }
                 String actualLine = actualReader.readLine();
-                while( actualLine != null && actualLine.trim().length() == 0 )
+                while (actualLine != null && actualLine.trim().isEmpty())
                 {
                     actualLine = actualReader.readLine();
                 }
@@ -570,7 +570,7 @@ class TestTextStripper
         File inDirExt = new File("target/test-input-ext");
         File outDirExt = new File("target/test-output-ext");
 
-            if ((filename == null) || (filename.length() == 0)) 
+            if (filename == null || filename.isEmpty())
             {
                 doTestDir(inDir, outDir);
                 if (inDirExt.exists())