Author: tilman
Date: Tue Aug 19 12:57:49 2025
New Revision: 1927886

Log:
PDFBOX-5660: improve test coverage

Modified:
   
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/PDFMergerUtilityTest.java

Modified: 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/PDFMergerUtilityTest.java
==============================================================================
--- 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/PDFMergerUtilityTest.java
       Tue Aug 19 12:45:15 2025        (r1927885)
+++ 
pdfbox/branches/3.0/pdfbox/src/test/java/org/apache/pdfbox/multipdf/PDFMergerUtilityTest.java
       Tue Aug 19 12:57:49 2025        (r1927886)
@@ -36,6 +36,8 @@ import org.apache.pdfbox.cos.COSDictiona
 import org.apache.pdfbox.cos.COSName;
 import org.apache.pdfbox.cos.COSObject;
 import org.apache.pdfbox.io.IOUtils;
+import org.apache.pdfbox.io.RandomAccessRead;
+import org.apache.pdfbox.io.RandomAccessReadBufferedFile;
 import org.apache.pdfbox.io.RandomAccessStreamCache.StreamCacheCreateFunction;
 import org.apache.pdfbox.pdmodel.PDDocument;
 import org.apache.pdfbox.pdmodel.PDDocumentCatalog;
@@ -779,17 +781,26 @@ class PDFMergerUtilityTest
         createSimpleFile(inFile1);
         createSimpleFile(inFile2);
 
-        try (OutputStream out = new FileOutputStream(outFile))
+        try (OutputStream out = new FileOutputStream(outFile);
+             // Unrelated: increase test coverage by testing RandomAccessRead
+             RandomAccessRead rar1 = new RandomAccessReadBufferedFile(inFile1);
+             RandomAccessRead rar2 = new RandomAccessReadBufferedFile(inFile2))
         {
             PDFMergerUtility merger = new PDFMergerUtility();
             merger.setDestinationStream(out);
+            assertEquals(out, merger.getDestinationStream());
 
-            merger.addSource(inFile1);
-            merger.addSource(inFile2);
+            merger.addSource(rar1);
+            merger.addSource(rar2);
 
             merger.mergeDocuments(IOUtils.createMemoryOnlyStreamCache());
         }
 
+        try (PDDocument doc = Loader.loadPDF(outFile))
+        {
+            assertEquals(2, doc.getNumberOfPages());
+        }
+
         Files.delete(inFile1.toPath());
         Files.delete(inFile2.toPath());
         Files.delete(outFile.toPath());

Reply via email to