svn commit: r1928782 - pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fixup/processor

[tilman]

Author: tilman
Date: Sat Sep 27 14:36:23 2025
New Revision: 1928782

Log:
PDFBOX-5660: optimize debugging; closes #265

Modified:
   
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fixup/processor/AcroFormOrphanWidgetsProcessor.java

Modified: 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fixup/processor/AcroFormOrphanWidgetsProcessor.java
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fixup/processor/AcroFormOrphanWidgetsProcessor.java
     Sat Sep 27 14:36:19 2025        (r1928781)
+++ 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fixup/processor/AcroFormOrphanWidgetsProcessor.java
     Sat Sep 27 14:36:23 2025        (r1928782)
@@ -172,19 +172,19 @@ public class AcroFormOrphanWidgetsProces
                     {
                         acroFormResources.put(fontName, 
widgetResources.getFont(fontName));
                         LOG.debug("added font resource to AcroForm from widget 
for font name {}",
-                                fontName.getName());
+                                () -> fontName.getName());
                     }
                 }
                 catch (IOException ioe)
                 {
                     LOG.debug("unable to add font to AcroForm for font name 
{}",
-                            fontName.getName());
+                            () -> fontName.getName());
                 }
             }
             else
             {
                 LOG.debug("font resource for widget was a subsetted font - 
ignored: {}",
-                        fontName.getName());
+                        () -> fontName.getName());
             }
         });
     }
@@ -239,17 +239,20 @@ public class AcroFormOrphanWidgetsProces
                 if (defaultResources.getFont(fontName) == null)
                 {
                     LOG.debug("trying to add missing font resource for field 
{}",
-                            field.getFullyQualifiedName());
+                            () -> field.getFullyQualifiedName());
                     FontMapper mapper = FontMappers.instance();
                     FontMapping<TrueTypeFont> fontMapping = 
mapper.getTrueTypeFont(fontName.getName() , null);
                     if (fontMapping != null)
                     {
                         PDType0Font pdFont = PDType0Font.load(document, 
fontMapping.getFont(), false);
-                        LOG.debug("looked up font for {} - found {}", 
fontName.getName(),
-                                fontMapping.getFont().getName());
+                        if (LOG.isDebugEnabled())
+                        {
+                            LOG.debug("looked up font for {} - found {}", 
fontName.getName(),
+                                    fontMapping.getFont().getName());
+                        }
                         defaultResources.put(fontName, pdFont);
                     }
-                    else
+                    else if (LOG.isDebugEnabled())
                     {
                         LOG.debug("no suitable font found for field {} for 
font name {}",
                                 field.getFullyQualifiedName(), 
fontName.getName());
@@ -258,8 +261,11 @@ public class AcroFormOrphanWidgetsProces
             }
             catch (IOException ioe)
             {
-                LOG.debug("unable to handle font resources for field {}: {}",
-                        field.getFullyQualifiedName(), ioe.getMessage());
+                if (LOG.isDebugEnabled())
+                {
+                    LOG.debug("unable to handle font resources for field {}: 
{}",
+                            field.getFullyQualifiedName(), ioe.getMessage());
+                }
             }
         }
     }