svn commit: r1929017 - pdfbox/branches/3.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font

[tilman]

Author: tilman
Date: Wed Oct  8 12:23:16 2025
New Revision: 1929017

Log:
PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #280

Modified:
   
pdfbox/branches/3.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDType1CFont.java

Modified: 
pdfbox/branches/3.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDType1CFont.java
==============================================================================
--- 
pdfbox/branches/3.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDType1CFont.java
   Wed Oct  8 12:23:12 2025        (r1929016)
+++ 
pdfbox/branches/3.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDType1CFont.java
   Wed Oct  8 12:23:16 2025        (r1929017)
@@ -84,7 +84,7 @@ public class PDType1CFont extends PDSimp
             PDStream ff3Stream = fd.getFontFile3();
             if (ff3Stream != null)
             {
-                try (RandomAccessRead randomAccessRead = 
fd.getFontFile3().getCOSObject()
+                try (RandomAccessRead randomAccessRead = 
ff3Stream.getCOSObject()
                         .createView())
                 {
                     if (randomAccessRead.length() == 0)
@@ -124,13 +124,14 @@ public class PDType1CFont extends PDSimp
         }
         else
         {
+            String baseFont = getBaseFont();
             FontMapping<FontBoxFont> mapping = FontMappers.instance()
-                                                          
.getFontBoxFont(getBaseFont(), fd);
+                                                          
.getFontBoxFont(baseFont, fd);
             genericFont = mapping.getFont();
             
             if (mapping.isFallback())
             {
-                LOG.warn("Using fallback font " + genericFont.getName() + " 
for " + getBaseFont());
+                LOG.warn("Using fallback font " + genericFont.getName() + " 
for " + baseFont);
             }
             isEmbedded = false;
         }