svn commit: r1928756 - pdfbox/branches/3.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action

[tilman]

Author: tilman
Date: Thu Sep 25 10:14:48 2025
New Revision: 1928756

Log:
PDFBOX-5660: optimize, as suggested by Valery Bokov; improve javadoc; closes 
#264

Modified:
   
pdfbox/branches/3.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionEmbeddedGoTo.java

Modified: 
pdfbox/branches/3.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionEmbeddedGoTo.java
==============================================================================
--- 
pdfbox/branches/3.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionEmbeddedGoTo.java
     Thu Sep 25 09:56:53 2025        (r1928755)
+++ 
pdfbox/branches/3.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionEmbeddedGoTo.java
     Thu Sep 25 10:14:48 2025        (r1928756)
@@ -124,13 +124,14 @@ public class PDActionEmbeddedGoTo extend
      * This will specify whether to open the destination document in a new 
window, in the same
      * window, or behave in accordance with the current user preference.
      *
-     * @return A flag specifying how to open the destination document.
+     * @return A flag specifying how to open the destination document, never 
null.
      */
     public OpenMode getOpenInNewWindow()
     {
-        if (getCOSObject().getDictionaryObject(COSName.NEW_WINDOW) instanceof 
COSBoolean)
+        COSBase dictionaryObject = 
getCOSObject().getDictionaryObject(COSName.NEW_WINDOW);
+        if (dictionaryObject instanceof COSBoolean)
         {
-            COSBoolean b = (COSBoolean) 
getCOSObject().getDictionaryObject(COSName.NEW_WINDOW);
+            COSBoolean b = (COSBoolean) dictionaryObject;
             return b.getValue() ? OpenMode.NEW_WINDOW : OpenMode.SAME_WINDOW;
         }
         return OpenMode.USER_PREFERENCE;