svn commit: r1928700 - pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action

[tilman]

Author: tilman
Date: Tue Sep 23 06:38:00 2025
New Revision: 1928700

Log:
PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #259

Modified:
   
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionLaunch.java
   
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionRemoteGoTo.java

Modified: 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionLaunch.java
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionLaunch.java
  Tue Sep 23 06:37:55 2025        (r1928699)
+++ 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionLaunch.java
  Tue Sep 23 06:38:00 2025        (r1928700)
@@ -17,6 +17,7 @@
 package org.apache.pdfbox.pdmodel.interactive.action;
 
 import java.io.IOException;
+import org.apache.pdfbox.cos.COSBase;
 import org.apache.pdfbox.cos.COSBoolean;
 
 import org.apache.pdfbox.cos.COSDictionary;
@@ -211,9 +212,10 @@ public class PDActionLaunch extends PDAc
      */
     public OpenMode getOpenInNewWindow()
     {
-        if (getCOSObject().getDictionaryObject(COSName.NEW_WINDOW) instanceof 
COSBoolean)
+        COSBase dictionaryObject = 
getCOSObject().getDictionaryObject(COSName.NEW_WINDOW);
+        if (dictionaryObject instanceof COSBoolean)
         {
-            COSBoolean b = (COSBoolean) 
getCOSObject().getDictionaryObject(COSName.NEW_WINDOW);
+            COSBoolean b = (COSBoolean) dictionaryObject;
             return b.getValue() ? OpenMode.NEW_WINDOW : OpenMode.SAME_WINDOW;
         }
         return OpenMode.USER_PREFERENCE;

Modified: 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionRemoteGoTo.java
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionRemoteGoTo.java
      Tue Sep 23 06:37:55 2025        (r1928699)
+++ 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionRemoteGoTo.java
      Tue Sep 23 06:38:00 2025        (r1928700)
@@ -118,9 +118,10 @@ public class PDActionRemoteGoTo extends
      */
     public OpenMode getOpenInNewWindow()
     {
-        if (getCOSObject().getDictionaryObject(COSName.NEW_WINDOW) instanceof 
COSBoolean)
+        COSBase dictionaryObject = 
getCOSObject().getDictionaryObject(COSName.NEW_WINDOW);
+        if (dictionaryObject instanceof COSBoolean)
         {
-            COSBoolean b = (COSBoolean) 
getCOSObject().getDictionaryObject(COSName.NEW_WINDOW);
+            COSBoolean b = (COSBoolean) dictionaryObject;
             return b.getValue() ? OpenMode.NEW_WINDOW : OpenMode.SAME_WINDOW;
         }
         return OpenMode.USER_PREFERENCE;