Author: tilman
Date: Tue Nov 4 10:53:37 2025
New Revision: 1929505
Log:
PDFBOX-5660: close input, as suggested by Valery Bokov; refactor; closes #311
Modified:
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java
Modified:
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java
==============================================================================
---
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java
Tue Nov 4 08:30:25 2025 (r1929504)
+++
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java
Tue Nov 4 10:53:37 2025 (r1929505)
@@ -21,11 +21,12 @@
package org.apache.xmpbox;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-
+import java.io.IOException;
import java.io.InputStream;
import java.util.stream.Stream;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+
import org.apache.xmpbox.xml.DomXmpParser;
import org.apache.xmpbox.xml.XmpParsingException;
import org.junit.jupiter.params.ParameterizedTest;
@@ -46,13 +47,14 @@ class TestXMPWithDefinedSchemas
@ParameterizedTest
@MethodSource("initializeParameters")
- void main(String path) throws XmpParsingException
+ void main(String path) throws XmpParsingException, IOException
{
- InputStream is = this.getClass().getResourceAsStream(path);
-
- DomXmpParser builder = new DomXmpParser();
- XMPMetadata rxmp = builder.parse(is);
- // ensure basic parsing was OK
- assertFalse(rxmp.getAllSchemas().isEmpty());
+ try (InputStream is = this.getClass().getResourceAsStream(path))
+ {
+ DomXmpParser builder = new DomXmpParser();
+ XMPMetadata rxmp = builder.parse(is);
+ // ensure basic parsing was OK
+ assertFalse(rxmp.getAllSchemas().isEmpty());
+ }
}
}