Author: tilman
Date: Tue Nov  4 10:53:45 2025
New Revision: 1929507

Log:
PDFBOX-5660: close input, as suggested by Valery Bokov; refactor; closes #311

Modified:
   
pdfbox/branches/3.0/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java

Modified: 
pdfbox/branches/3.0/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java
==============================================================================
--- 
pdfbox/branches/3.0/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java
   Tue Nov  4 10:53:41 2025        (r1929506)
+++ 
pdfbox/branches/3.0/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java
   Tue Nov  4 10:53:45 2025        (r1929507)
@@ -21,11 +21,13 @@
 
 package org.apache.xmpbox;
 
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import java.io.IOException;
 
 import java.io.InputStream;
 import java.util.stream.Stream;
 
+import static org.junit.jupiter.api.Assertions.assertFalse;
+
 import org.apache.xmpbox.xml.DomXmpParser;
 import org.apache.xmpbox.xml.XmpParsingException;
 import org.junit.jupiter.params.ParameterizedTest;
@@ -46,13 +48,14 @@ class TestXMPWithDefinedSchemas
 
     @ParameterizedTest
     @MethodSource("initializeParameters")
-    void main(String path) throws XmpParsingException
+    void main(String path) throws XmpParsingException, IOException
     {
-        InputStream is = this.getClass().getResourceAsStream(path);
-
-        DomXmpParser builder = new DomXmpParser();
-        XMPMetadata rxmp = builder.parse(is);
-        // ensure basic parsing was OK
-        assertTrue(rxmp.getAllSchemas().size()>0);
+        try (InputStream is = this.getClass().getResourceAsStream(path))
+        {
+            DomXmpParser builder = new DomXmpParser();
+            XMPMetadata rxmp = builder.parse(is);
+            // ensure basic parsing was OK
+            assertFalse(rxmp.getAllSchemas().isEmpty());
+        }
     }
 }

Reply via email to