Author: tilman
Date: Mon Dec 15 16:34:00 2025
New Revision: 1930597
Log:
PDFBOX-3882: Sonar fix
Modified:
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/xml/DomXmpParserTest.java
Modified:
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/xml/DomXmpParserTest.java
==============================================================================
---
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/xml/DomXmpParserTest.java
Mon Dec 15 16:33:53 2025 (r1930596)
+++
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/xml/DomXmpParserTest.java
Mon Dec 15 16:34:00 2025 (r1930597)
@@ -543,13 +543,14 @@ class DomXmpParserTest
" </rdf:RDF>\n" +
"</x:xmpmeta>\n" +
"<?xpacket end='w'?>";
+ final DomXmpParser xmpParser1 = new DomXmpParser();
XmpParsingException ex = assertThrows(
XmpParsingException.class,
- () -> new
DomXmpParser().parse(s.getBytes(StandardCharsets.UTF_8)));
+ () -> xmpParser1.parse(s.getBytes(StandardCharsets.UTF_8)));
assertEquals("Invalid array type, expecting Bag and found Seq
[prefix=dc; name=subject]", ex.getMessage());
- DomXmpParser xmpParser = new DomXmpParser();
- xmpParser.setStrictParsing(false);
- XMPMetadata xmp = xmpParser.parse(s.getBytes(StandardCharsets.UTF_8));
+ final DomXmpParser xmpParser2 = new DomXmpParser();
+ xmpParser2.setStrictParsing(false);
+ XMPMetadata xmp = xmpParser2.parse(s.getBytes(StandardCharsets.UTF_8));
DublinCoreSchema dublinCoreSchema = xmp.getDublinCoreSchema();
List<String> subjects = dublinCoreSchema.getSubjects();
assertEquals(2, subjects.size());
@@ -573,13 +574,14 @@ class DomXmpParserTest
" </rdf:Description>\n" +
" </rdf:RDF>\n" +
"</x:xmpmeta><?xpacket end=\"r\"?>";
+ final DomXmpParser xmpParser1 = new DomXmpParser();
XmpParsingException ex = assertThrows(
XmpParsingException.class,
- () -> new
DomXmpParser().parse(s.getBytes(StandardCharsets.UTF_8)));
+ () -> xmpParser1.parse(s.getBytes(StandardCharsets.UTF_8)));
assertEquals("No type defined for
{http://ns.adobe.com/xap/1.0/sType/Dimensions#}X";, ex.getMessage());
- DomXmpParser xmpParser = new DomXmpParser();
- xmpParser.setStrictParsing(false);
- XMPMetadata xmp = xmpParser.parse(s.getBytes(StandardCharsets.UTF_8));
+ final DomXmpParser xmpParser2 = new DomXmpParser();
+ xmpParser2.setStrictParsing(false);
+ XMPMetadata xmp = xmpParser2.parse(s.getBytes(StandardCharsets.UTF_8));
XMPPageTextSchema pageTextSchema = xmp.getPageTextSchema();
DimensionsType dim = (DimensionsType)
pageTextSchema.getProperty(XMPPageTextSchema.MAX_PAGE_SIZE);
assertEquals("DimensionsType{null x null null}", dim.toString());
@@ -601,13 +603,14 @@ class DomXmpParserTest
" pdf:Author=\"edocslib\"/>\n" +
"</rdf:RDF>\n" +
"<?xpacket end='r'?>";
+ final DomXmpParser xmpParser1 = new DomXmpParser();
XmpParsingException ex = assertThrows(
XmpParsingException.class,
- () -> new
DomXmpParser().parse(s.getBytes(StandardCharsets.UTF_8)));
+ () -> xmpParser1.parse(s.getBytes(StandardCharsets.UTF_8)));
assertEquals("No type defined for
{http://ns.adobe.com/pdf/1.3/}Author";, ex.getMessage());
- DomXmpParser xmpParser = new DomXmpParser();
- xmpParser.setStrictParsing(false);
- XMPMetadata xmp = xmpParser.parse(s.getBytes(StandardCharsets.UTF_8));
+ final DomXmpParser xmpParser2 = new DomXmpParser();
+ xmpParser2.setStrictParsing(false);
+ XMPMetadata xmp = xmpParser2.parse(s.getBytes(StandardCharsets.UTF_8));
AdobePDFSchema adobePDFSchema = xmp.getAdobePDFSchema();
TextType tt = (TextType) adobePDFSchema.getProperty("Author");
assertEquals("[Author=TextType:edocslib]", tt.toString());
@@ -622,9 +625,10 @@ class DomXmpParserTest
" <rdf:RDF xmlns:iX=\"http://ns.adobe.com/iX/1.0/\";
xmlns:rdf=\"http://www.w3.org/1999/02/22-rdf-syntax-ns#\";>\n" +
" </rdf:RDF>\n" +
"</x:xapmeta><?xpacket end='w'?>";
+ final DomXmpParser xmpParser = new DomXmpParser();
XmpParsingException ex = assertThrows(
XmpParsingException.class,
- () -> new
DomXmpParser().parse(s.getBytes(StandardCharsets.UTF_8)));
+ () -> xmpParser.parse(s.getBytes(StandardCharsets.UTF_8)));
assertEquals("Expecting local name 'xmpmeta' and found 'xapmeta'",
ex.getMessage());
}
@@ -639,9 +643,10 @@ class DomXmpParserTest
" </rdf:Description>\n" +
" </rdf:RDF>\n" +
"</x:xmpmeta><?xpacket ends=\"w\" ?>";
+ final DomXmpParser xmpParser = new DomXmpParser();
XmpParsingException ex = assertThrows(
XmpParsingException.class,
- () -> new
DomXmpParser().parse(s.getBytes(StandardCharsets.UTF_8)));
+ () -> xmpParser.parse(s.getBytes(StandardCharsets.UTF_8)));
assertEquals("Excepted xpacket 'end' attribute (must be present and
placed in first)", ex.getMessage());
}
@@ -656,9 +661,10 @@ class DomXmpParserTest
" </rdf:Description>\n" +
" </rdf:RDF>\n" +
"</x:xmpmeta><?xpacket end=\"k\" ?>";
+ final DomXmpParser xmpParser = new DomXmpParser();
XmpParsingException ex = assertThrows(
XmpParsingException.class,
- () -> new
DomXmpParser().parse(s.getBytes(StandardCharsets.UTF_8)));
+ () -> xmpParser.parse(s.getBytes(StandardCharsets.UTF_8)));
assertEquals("Excepted xpacket 'end' attribute with value 'r' or 'w'
", ex.getMessage());
}
@@ -669,9 +675,10 @@ class DomXmpParserTest
"<?xpacket begin=\"\" id=\"W5M0MpCehiHzreSzNTczkc9d\" ?>"
+
" <x:xmpmeta xmlns:x=\"adobe:ns:meta/\"/>\n" +
"<?xpacket end=\"w\" ?>";
+ final DomXmpParser xmpParser = new DomXmpParser();
XmpParsingException ex = assertThrows(
XmpParsingException.class,
- () -> new
DomXmpParser().parse(s.getBytes(StandardCharsets.UTF_8)));
+ () -> xmpParser.parse(s.getBytes(StandardCharsets.UTF_8)));
assertEquals("No rdf description found in xmp", ex.getMessage());
}
}
