Author: tilman
Date: Tue Feb 17 20:37:35 2026
New Revision: 1931917
Log:
PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #421
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/StandardSecurityHandler.java
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/StandardSecurityHandler.java
==============================================================================
---
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/StandardSecurityHandler.java
Tue Feb 17 20:37:31 2026 (r1931916)
+++
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/StandardSecurityHandler.java
Tue Feb 17 20:37:35 2026 (r1931917)
@@ -243,34 +243,29 @@ public final class StandardSecurityHandl
AccessPermission currentAccessPermission;
byte[] encryptedKey;
- byte[] passwordBytes;
+ byte[] passwordBytes = password.getBytes(passwordCharset);
boolean isOwnerPassword;
- if( isOwnerPassword(password.getBytes(passwordCharset), userKey,
ownerKey,
+ if (isOwnerPassword(passwordBytes, userKey, ownerKey,
dicPermissions, documentIDBytes, dicRevision,
dicLength, encryptMetadata) )
{
currentAccessPermission =
AccessPermission.getOwnerAccessPermission();
setCurrentAccessPermission(currentAccessPermission);
- if (dicRevision == REVISION_5 || dicRevision == REVISION_6)
+ if (dicRevision != REVISION_5 && dicRevision != REVISION_6)
{
- passwordBytes = password.getBytes(passwordCharset);
- }
- else
- {
- passwordBytes =
getUserPassword234(password.getBytes(passwordCharset),
+ passwordBytes = getUserPassword234(passwordBytes,
ownerKey, dicRevision, dicLength );
}
isOwnerPassword = true;
}
- else if( isUserPassword(password.getBytes(passwordCharset), userKey,
ownerKey,
+ else if (isUserPassword(passwordBytes, userKey, ownerKey,
dicPermissions, documentIDBytes, dicRevision,
dicLength, encryptMetadata) )
{
currentAccessPermission = new AccessPermission(dicPermissions);
currentAccessPermission.setReadOnly();
setCurrentAccessPermission(currentAccessPermission);
- passwordBytes = password.getBytes(passwordCharset);
isOwnerPassword = false;
}
else
