This is an automated email from the ASF dual-hosted git repository.
laiyingchun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pegasus.git
The following commit(s) were added to refs/heads/master by this push:
new 9300a2926 fix(build): Fix Cpp build errors in recent github actions
(#1834)
9300a2926 is described below
commit 9300a2926589fa2dad8527e0f35ccaf6ab7be0be
Author: Yingchun Lai <[email protected]>
AuthorDate: Fri Jan 5 14:37:27 2024 +0800
fix(build): Fix Cpp build errors in recent github actions (#1834)
Mute errors like the follows, the Pegasus codebase will be checked by
clang-format, so it's safe to enable the CMake option
(-Wno-misleading-indentation).
```
#
.../thirdparty/output/include/boost/lexical_cast/detail/lcast_unsigned_converters.hpp:149:17:
error: this 'while' clause does not guard... [-Werror=misleading-indentation]
# 149 | inline CharT* main_convert_loop() BOOST_NOEXCEPT {
# | ^~~~~
```
---
cmake_modules/BaseFunctions.cmake | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/cmake_modules/BaseFunctions.cmake
b/cmake_modules/BaseFunctions.cmake
index b1dff9b60..33c819fbb 100644
--- a/cmake_modules/BaseFunctions.cmake
+++ b/cmake_modules/BaseFunctions.cmake
@@ -222,6 +222,13 @@ function(dsn_setup_compiler_flags)
add_compile_options(-Wno-deprecated-declarations)
add_compile_options(-Wno-inconsistent-missing-override)
add_compile_options(-Wno-attributes)
+
+ # Mute errors like the follows, the Pegasus codebase will be checked by
clang-format, so it's safe to mute it.
+ #
/__w/incubator-pegasus/incubator-pegasus/thirdparty/output/include/boost/lexical_cast/detail/lcast_unsigned_converters.hpp:149:17:
error: this 'while' clause does not guard... [-Werror=misleading-indentation]
+ # 149 | inline CharT* main_convert_loop() BOOST_NOEXCEPT {
+ # | ^~~~~
+ add_compile_options(-Wno-misleading-indentation)
+
# -fno-omit-frame-pointer
# use frame pointers to allow simple stack frame walking for backtraces.
# This has a small perf hit but worth it for the ability to profile in
production
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
