This is an automated email from the ASF dual-hosted git repository.
wangdan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pegasus.git
The following commit(s) were added to refs/heads/master by this push:
new 097068d2f feat(logging): Introduce spdlog to thirdparty (#2084)
097068d2f is described below
commit 097068d2fa6dfd9ff61c4f51cdc1c33d3b1f5d29
Author: Yingchun Lai <[email protected]>
AuthorDate: Thu Aug 1 10:52:52 2024 +0800
feat(logging): Introduce spdlog to thirdparty (#2084)
This is a previous work of
https://github.com/apache/incubator-pegasus/pull/2083.
This patch introduces [spdlog](https://github.com/gabime/spdlog) as a
thirdparty
to prepare the docker image, then the #2083 can use it to run CI.
spdlog is a very fast C++ logging library, you can see the benchmarks:
https://github.com/gabime/spdlog?tab=readme-ov-file#benchmarks. spdlog using
`libfmt` to format message content, it is fast and compatible with the
current
logging practice in Pegasus. It's a good choice to replace the current
`simple_logger` or `screen_logger` implementation in Pegasus.
---
thirdparty/CMakeLists.txt | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/thirdparty/CMakeLists.txt b/thirdparty/CMakeLists.txt
index 710598354..d197e26b5 100644
--- a/thirdparty/CMakeLists.txt
+++ b/thirdparty/CMakeLists.txt
@@ -473,3 +473,19 @@ ExternalProject_Add(http-parser
DOWNLOAD_NO_PROGRESS true
)
+ExternalProject_Add(spdlog
+ URL https://github.com/gabime/spdlog/archive/refs/tags/v1.14.1.tar.gz
+ URL_MD5 f2c3f15c20e67b261836ff7bfda302cf
+ PATCH_COMMAND ""
+ CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${TP_OUTPUT}
+ -DSPDLOG_ENABLE_PCH=ON
+ -DSPDLOG_BUILD_PIC=ON
+ -DSPDLOG_FMT_EXTERNAL=ON
+ -DSPDLOG_NO_EXCEPTIONS=ON
+ -Dfmt_DIR=${TP_OUTPUT}/lib/cmake/fmt
+ BUILD_COMMAND make -j${PARALLEL}
+ INSTALL_COMMAND make install
+ DEPENDS fmt
+ DOWNLOAD_EXTRACT_TIMESTAMP true
+ DOWNLOAD_NO_PROGRESS true
+)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
