This is an automated email from the ASF dual-hosted git repository.
wangdan pushed a commit to branch fix-github-ubuntu-2004-runner-removed
in repository https://gitbox.apache.org/repos/asf/incubator-pegasus.git
The following commit(s) were added to
refs/heads/fix-github-ubuntu-2004-runner-removed by this push:
new 0cc9dc283 downgrade golangci-lint to v1.56.2
0cc9dc283 is described below
commit 0cc9dc283d1e11e21fa23cb6613114bc37c3c21d
Author: Dan Wang <[email protected]>
AuthorDate: Fri Apr 25 18:38:28 2025 +0800
downgrade golangci-lint to v1.56.2
---
.github/workflows/lint_and_test_admin-cli.yml | 2 +-
.github/workflows/lint_and_test_collector.yml | 2 +-
.github/workflows/lint_and_test_go-client.yml | 2 +-
.github/workflows/lint_and_test_pegic.yml | 2 +-
.github/workflows/regular-build.yml | 6 +++---
.golangci.yml | 12 ++++++++++--
6 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/.github/workflows/lint_and_test_admin-cli.yml
b/.github/workflows/lint_and_test_admin-cli.yml
index 8ae651bd7..f9fc147bb 100644
--- a/.github/workflows/lint_and_test_admin-cli.yml
+++ b/.github/workflows/lint_and_test_admin-cli.yml
@@ -49,7 +49,7 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
- version: v1.64.8
+ version: v1.56.2
working-directory: ./admin-cli
build:
diff --git a/.github/workflows/lint_and_test_collector.yml
b/.github/workflows/lint_and_test_collector.yml
index 743d14cde..9fbbf252b 100644
--- a/.github/workflows/lint_and_test_collector.yml
+++ b/.github/workflows/lint_and_test_collector.yml
@@ -73,7 +73,7 @@ jobs:
- name: Lint
uses: golangci/golangci-lint-action@v3
with:
- version: v1.64.8
+ version: v1.56.2
working-directory: ./collector
build:
diff --git a/.github/workflows/lint_and_test_go-client.yml
b/.github/workflows/lint_and_test_go-client.yml
index 54f65f9b0..045c87f65 100644
--- a/.github/workflows/lint_and_test_go-client.yml
+++ b/.github/workflows/lint_and_test_go-client.yml
@@ -76,7 +76,7 @@ jobs:
- name: Lint Go Client
uses: golangci/golangci-lint-action@v3
with:
- version: v1.64.8
+ version: v1.56.2
working-directory: ./go-client
build_server:
diff --git a/.github/workflows/lint_and_test_pegic.yml
b/.github/workflows/lint_and_test_pegic.yml
index f72eab9f4..fe5ee44d5 100644
--- a/.github/workflows/lint_and_test_pegic.yml
+++ b/.github/workflows/lint_and_test_pegic.yml
@@ -45,7 +45,7 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
- version: v1.64.8
+ version: v1.56.2
working-directory: ./pegic
build:
diff --git a/.github/workflows/regular-build.yml
b/.github/workflows/regular-build.yml
index bce8f8f98..3eac91eb2 100644
--- a/.github/workflows/regular-build.yml
+++ b/.github/workflows/regular-build.yml
@@ -102,7 +102,7 @@ jobs:
- name: Lint go-client
uses: golangci/golangci-lint-action@v3
with:
- version: v1.64.8
+ version: v1.56.2
working-directory: ./go-client
- name: Build admin-cli
run: make
@@ -110,7 +110,7 @@ jobs:
- name: Lint admin-cli
uses: golangci/golangci-lint-action@v3
with:
- version: v1.64.8
+ version: v1.56.2
working-directory: ./admin-cli
- name: Build pegic
run: make
@@ -118,7 +118,7 @@ jobs:
- name: Lint pegic
uses: golangci/golangci-lint-action@v3
with:
- version: v1.64.8
+ version: v1.56.2
working-directory: ./pegic
build_java:
diff --git a/.golangci.yml b/.golangci.yml
index e3b700499..013f1cd61 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -16,13 +16,21 @@
# under the License.
---
linters:
+ # TODO(wangdan): consider replacing 'golint' with 'revive' because 'golint'
is
+ # deprecated (since v1.41.0, its repository has been archived by the owner).
+ #
+ # After Go is upgraded to v1.22, consider replacing 'exportloopref' with
'copyloopvar'
+ # because as of Go 1.22, the problem resolved by 'exportloopref' no longer
occurs and
+ # fixed by Go team (https://go.dev/blog/loopvar-preview).
+ #
+ # After all of above are bumped, consider upgrading golangci-lint (e.g. to
v1.64.8).
enable:
- gofmt
- goimports
- - revive
+ - golint
- bodyclose
- exhaustive
- - copyloopvar
+ - exportloopref
linters-settings:
exhaustive:
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
