This is an automated email from the ASF dual-hosted git repository. fanningpj pushed a commit to branch wip-jackson-simplification-cluster-sample in repository https://gitbox.apache.org/repos/asf/incubator-pekko-samples.git
commit b1f6fe6070e6394122b2e948a50ac23607786673 Author: Johan Andrén <[email protected]> AuthorDate: Tue Nov 19 10:06:42 2019 +0100 Enable java compiler arg -parameters and simplify jackson annotations --- akka-sample-cluster-java/build.sbt | 2 +- akka-sample-cluster-java/pom.xml | 1 + .../src/main/java/sample/cluster/stats/StatsService.java | 8 +++----- .../src/main/java/sample/cluster/stats/StatsWorker.java | 8 ++------ .../src/main/java/sample/cluster/transformation/Worker.java | 6 ++---- 5 files changed, 9 insertions(+), 16 deletions(-) diff --git a/akka-sample-cluster-java/build.sbt b/akka-sample-cluster-java/build.sbt index c8f9189..2b03f89 100644 --- a/akka-sample-cluster-java/build.sbt +++ b/akka-sample-cluster-java/build.sbt @@ -10,7 +10,7 @@ lazy val `akka-sample-cluster-java` = project organization := "com.typesafe.akka.samples", scalaVersion := "2.13.1", Compile / scalacOptions ++= Seq("-deprecation", "-feature", "-unchecked", "-Xlog-reflective-calls", "-Xlint"), - Compile / javacOptions ++= Seq("-Xlint:unchecked", "-Xlint:deprecation"), + Compile / javacOptions ++= Seq("-parameters", "-Xlint:unchecked", "-Xlint:deprecation"), run / javaOptions ++= Seq("-Xms128m", "-Xmx1024m", "-Djava.library.path=./target/native"), libraryDependencies ++= Seq( "com.typesafe.akka" %% "akka-actor-typed" % akkaVersion, diff --git a/akka-sample-cluster-java/pom.xml b/akka-sample-cluster-java/pom.xml index 149ca4b..2c7ba9a 100644 --- a/akka-sample-cluster-java/pom.xml +++ b/akka-sample-cluster-java/pom.xml @@ -55,6 +55,7 @@ <fork>true</fork> <compilerArgs> <arg>-Xlint</arg> + <arg>-parameters</arg> </compilerArgs> </configuration> </plugin> diff --git a/akka-sample-cluster-java/src/main/java/sample/cluster/stats/StatsService.java b/akka-sample-cluster-java/src/main/java/sample/cluster/stats/StatsService.java index a6c9e8f..5eafccc 100644 --- a/akka-sample-cluster-java/src/main/java/sample/cluster/stats/StatsService.java +++ b/akka-sample-cluster-java/src/main/java/sample/cluster/stats/StatsService.java @@ -7,7 +7,6 @@ import akka.actor.typed.javadsl.ActorContext; import akka.actor.typed.javadsl.Behaviors; import akka.actor.typed.javadsl.Receive; import com.fasterxml.jackson.annotation.JsonCreator; -import com.fasterxml.jackson.annotation.JsonProperty; import sample.cluster.CborSerializable; import java.util.Arrays; @@ -19,8 +18,7 @@ public final class StatsService extends AbstractBehavior<StatsService.Command> { public final static class ProcessText implements Command { public final String text; public final ActorRef<Response> replyTo; - @JsonCreator - public ProcessText(@JsonProperty("text") String text, @JsonProperty("replyTo") ActorRef<Response> replyTo) { + public ProcessText(String text, ActorRef<Response> replyTo) { this.text = text; this.replyTo = replyTo; } @@ -33,7 +31,7 @@ public final class StatsService extends AbstractBehavior<StatsService.Command> { public static final class JobResult implements Response { public final double meanWordLength; @JsonCreator - public JobResult(@JsonProperty("meanWordLength") double meanWordLength) { + public JobResult(double meanWordLength) { this.meanWordLength = meanWordLength; } @Override @@ -46,7 +44,7 @@ public final class StatsService extends AbstractBehavior<StatsService.Command> { public static final class JobFailed implements Response { public final String reason; @JsonCreator - public JobFailed(@JsonProperty("reason") String reason) { + public JobFailed(String reason) { this.reason = reason; } @Override diff --git a/akka-sample-cluster-java/src/main/java/sample/cluster/stats/StatsWorker.java b/akka-sample-cluster-java/src/main/java/sample/cluster/stats/StatsWorker.java index 6b956bd..13a4357 100644 --- a/akka-sample-cluster-java/src/main/java/sample/cluster/stats/StatsWorker.java +++ b/akka-sample-cluster-java/src/main/java/sample/cluster/stats/StatsWorker.java @@ -10,8 +10,6 @@ import akka.actor.typed.javadsl.AbstractBehavior; import akka.actor.typed.javadsl.ActorContext; import akka.actor.typed.javadsl.Behaviors; import akka.actor.typed.javadsl.Receive; -import com.fasterxml.jackson.annotation.JsonCreator; -import com.fasterxml.jackson.annotation.JsonProperty; import sample.cluster.CborSerializable; public final class StatsWorker extends AbstractBehavior<StatsWorker.Command> { @@ -20,8 +18,7 @@ public final class StatsWorker extends AbstractBehavior<StatsWorker.Command> { public static final class Process implements Command { public final String word; public final ActorRef<Processed> replyTo; - @JsonCreator - public Process(@JsonProperty("word") String word, @JsonProperty("replyTo") ActorRef<Processed> replyTo) { + public Process(String word, ActorRef<Processed> replyTo) { this.word = word; this.replyTo = replyTo; } @@ -32,8 +29,7 @@ public final class StatsWorker extends AbstractBehavior<StatsWorker.Command> { public static final class Processed implements CborSerializable { public final String word; public final int length; - @JsonCreator - public Processed(@JsonProperty("word") String word, @JsonProperty("length") int length) { + public Processed(String word, int length) { this.word = word; this.length = length; } diff --git a/akka-sample-cluster-java/src/main/java/sample/cluster/transformation/Worker.java b/akka-sample-cluster-java/src/main/java/sample/cluster/transformation/Worker.java index 4931149..8e306b3 100644 --- a/akka-sample-cluster-java/src/main/java/sample/cluster/transformation/Worker.java +++ b/akka-sample-cluster-java/src/main/java/sample/cluster/transformation/Worker.java @@ -6,7 +6,6 @@ import akka.actor.typed.javadsl.Behaviors; import akka.actor.typed.receptionist.Receptionist; import akka.actor.typed.receptionist.ServiceKey; import com.fasterxml.jackson.annotation.JsonCreator; -import com.fasterxml.jackson.annotation.JsonProperty; import sample.cluster.CborSerializable; //#worker @@ -19,8 +18,7 @@ public class Worker { public static final class TransformText implements Command { public final String text; - @JsonCreator - public TransformText(@JsonProperty("text") String text, @JsonProperty("replyTo") ActorRef<TextTransformed> replyTo) { + public TransformText(String text, ActorRef<TextTransformed> replyTo) { this.text = text; this.replyTo = replyTo; } @@ -29,7 +27,7 @@ public class Worker { public static final class TextTransformed implements CborSerializable { public final String text; @JsonCreator - public TextTransformed(@JsonProperty("text") String text) { + public TextTransformed(String text) { this.text = text; } } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
