jrudolph commented on code in PR #4:
URL: https://github.com/apache/incubator-pekko/pull/4#discussion_r1012687269
##########
akka-stream/src/main/scala/akka/stream/impl/Timers.scala:
##########
@@ -275,11 +275,15 @@ import akka.stream.stage._
val now = System.nanoTime()
// Timer is reliably cancelled if a regular element arrives first.
Scheduler rather schedules too late
// than too early so the deadline must have passed at this time.
- assert(
- now - nextDeadline >= 0,
Review Comment:
> In this case it would help the user to get a WARN log. It should not be
DEBUG since it's not expected to happen. And even for the people that stumbled
upon its still rare.
No strong opinion on that but it seems a bit arbitrary to put that warning
into this code especially, since here we can just fix it without any bad effect
for the user (even though it might be a problem somewhere else).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
