This is an automated email from the ASF dual-hosted git repository. pjfanning pushed a commit to branch fix-scala3-dollar-identifier in repository https://gitbox.apache.org/repos/asf/pekko-grpc.git
commit c470c3f0baf86a43eb28a608071946ffcac7920a Author: PJ Fanning <[email protected]> AuthorDate: Fri Sep 4 18:41:13 2026 +0100 Drop stray $ from PekkoHttpServerProviderJava test object name Motivation: Scala 3.9.0 added syntax warning E230, which flags identifiers containing `$` as reserved for internal compiler use. The interop-tests test sources are compiled with `-Werror`, so `object PekkoHttpServerProviderJava$` turns that warning into a build failure: -- [E230] Syntax Warning: GrpcInteropSpec.scala:76:7 The identifier `PekkoHttpServerProviderJava$` should not contain `$`, which is reserved for internal compiler use. The trailing `$` is not intentional. It is a leftover from the Akka to Pekko rename in 7ad0b5d6; the equivalent object in the sbt scripted test copy of this spec is named `PekkoHttpServerProviderJava` with no `$`. Modification: Rename the object to `PekkoHttpServerProviderJava` and update its single reference in `Servers.Pekko.Java`. Both are in the same file, and the name is test-only, so nothing outside this spec is affected. Result: interop-tests test sources compile under Scala 3.9.0 with `-Werror`. This unblocks bumping `scala3Next` to 3.9.0. Tests: - sbt -batch "++3.9.0!" interop-tests/Test/compile - success - sbt -batch "++3.9.0!" Test/compile - success (whole build, no other E230 warnings; run on a tree that also carried the sbt-plugin Scala version change needed for the 3.9.0 bump) - scalafmt --list --mode diff-ref=upstream/main - no files to reformat References: Refs #881 --- .../test/scala/org/apache/pekko/grpc/interop/GrpcInteropSpec.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/interop-tests/src/test/scala/org/apache/pekko/grpc/interop/GrpcInteropSpec.scala b/interop-tests/src/test/scala/org/apache/pekko/grpc/interop/GrpcInteropSpec.scala index a9299c2d..713d1bc1 100644 --- a/interop-tests/src/test/scala/org/apache/pekko/grpc/interop/GrpcInteropSpec.scala +++ b/interop-tests/src/test/scala/org/apache/pekko/grpc/interop/GrpcInteropSpec.scala @@ -50,7 +50,7 @@ class GrpcInteropPekkoJavaWithPekkoHttpJavaSpec extends GrpcInteropTests(Servers object Servers { val IoGrpc = IoGrpcJavaServerProvider object Pekko { - val Java = PekkoHttpServerProviderJava$ + val Java = PekkoHttpServerProviderJava val Scala = PekkoHttpServerProviderScala } } @@ -73,7 +73,7 @@ object Clients { //--- Some more providers -object PekkoHttpServerProviderJava$ extends PekkoHttpServerProvider { +object PekkoHttpServerProviderJava extends PekkoHttpServerProvider { val label: String = "pekko-grpc java server" val pendingCases = --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
